Bugzilla – Attachment 150640 Details for
Bug 33626
compare_es_to_db.pl does not work with Search::Elasticsearch 7.0
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33626: Remove invalid params
Bug-33626-Remove-invalid-params.patch (text/plain), 1.49 KB, created by
Jonathan Druart
on 2023-05-04 10:37:16 UTC
(
hide
)
Description:
Bug 33626: Remove invalid params
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-05-04 10:37:16 UTC
Size:
1.49 KB
patch
obsolete
>From 437c665cebe646caf1243fd4031a2f29d0b4a54e Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Thu, 27 Apr 2023 11:23:03 +0000 >Subject: [PATCH] Bug 33626: Remove invalid params > >This patch reformats the params passed to scroll_helper as defined here: >https://metacpan.org/pod/Search::Elasticsearch::Client::7_0::Scroll > >To test: >1 - perl misc/maintenance/compare_es_to_db.pl >2 - It dies: >[Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55. >3 - Apply patch >4 - Repeat >5 - It succeeds! > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > misc/maintenance/compare_es_to_db.pl | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/misc/maintenance/compare_es_to_db.pl b/misc/maintenance/compare_es_to_db.pl >index 2fb67e3629f..5b12814b419 100755 >--- a/misc/maintenance/compare_es_to_db.pl >+++ b/misc/maintenance/compare_es_to_db.pl >@@ -54,14 +54,12 @@ foreach my $index ( ('biblios','authorities') ){ > # The scroll lets us iterate through, it fetches chunks of 'size' as we move through > my $scroll = $es->scroll_helper( > index => $searcher->index_name, >- size => 5000, > body => { >+ size => 5000, > query => { > match_all => {} > }, >- stored_fields => [] > }, >- scroll_in_qs => 1, > ); > > my @es_ids; >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33626
:
150289
| 150640