Bug 33626 - compare_es_to_db.pl does not work with Search::Elasticsearch 7.0
Summary: compare_es_to_db.pl does not work with Search::Elasticsearch 7.0
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 25439
  Show dependency tree / graph
 
Reported: 2023-04-27 11:22 UTC by Nick Clemens (kidclamp)
Modified: 2024-07-04 20:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14
Circulation function:

Attachments
Bug 33626: Remove invalid params (1.41 KB, patch)
2023-04-27 11:27 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 33626: Remove invalid params (1.49 KB, patch)
2023-05-04 10:37 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-04-27 11:22:47 UTC 
[Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55.
Comment 1 Nick Clemens (kidclamp) 2023-04-27 11:27:15 UTC 
Created attachment 150289 [details] [review]
Bug 33626: Remove invalid params

This patch reformats the params passed to scroll_helper as defined here:
https://metacpan.org/pod/Search::Elasticsearch::Client::7_0::Scroll

To test:
1 - perl misc/maintenance/compare_es_to_db.pl
2 - It dies:
[Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55.
3 - Apply patch
4 - Repeat
5 - It succeeds!
Comment 2 Jonathan Druart 2023-05-04 10:37:16 UTC 
Created attachment 150640 [details] [review]
Bug 33626: Remove invalid params

This patch reformats the params passed to scroll_helper as defined here:
https://metacpan.org/pod/Search::Elasticsearch::Client::7_0::Scroll

To test:
1 - perl misc/maintenance/compare_es_to_db.pl
2 - It dies:
[Param] ** Unknown param (scroll_in_qs) in (search) request. , called from sub Search::Elasticsearch::Client::7_0::Direct::scroll_helper at misc/maintenance/compare_es_to_db.pl line 55.
3 - Apply patch
4 - Repeat
5 - It succeeds!

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Tomás Cohen Arazi (tcohen) 2023-05-05 13:15:44 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 4 Martin Renvoize (ashimema) 2023-05-12 15:12:44 UTC 
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 5 Lucas Gass (lukeg) 2023-06-13 16:05:24 UTC 
Backported to 22.05.x for upcoming 22.05.14
Comment 6 Danyon Sewell 2023-07-20 00:16:58 UTC 
Not backporting to 21.11.x