Bugzilla – Attachment 15638 Details for
Bug 9696
Remove YUI styling from buttons on patron card creator edit pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages
SIGNED-OFF-Bug-9696---Remove-YUI-styling-from-butt.patch (text/plain), 9.56 KB, created by
Bernardo Gonzalez Kriegel
on 2013-02-22 19:58:41 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-02-22 19:58:41 UTC
Size:
9.56 KB
patch
obsolete
>From e83fc4962a207b59f7e916406fb8cd1e098d7547 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 22 Feb 2013 09:52:10 -0500 >Subject: [PATCH] [SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on > patron card creator edit pages > >Submit and cancel buttons on patron card creator edit pages should not >be styled differently than other submit and cancel controls. > >This patch removes YUI styling of these controls and makes them >consistent with controls on other Koha pages. The "Cancel" button has >been removed altogether from the batch edit page since there is not a >corresponding submit button. > >To test, got to the patron card creator and edit a batch, a layout, a >profile, and a template. Submit and cancel controls should look correct >and work correctly. > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> > >Comment: Work as described. Works and looks well. No errors. > >Note: It's true that edit batch has not a submit button, but >on the other managed pages (layout, profile, template) cancel >aborts editing and takes you to a list of objects (layout, etc.) >Now if we selected the wrong batch, we need to click on left menu o >back button (yay). Are we loosing a consistent interface? >Just thinking. >--- > .../prog/en/modules/patroncards/edit-batch.tt | 19 ------------ > .../prog/en/modules/patroncards/edit-layout.tt | 31 ++------------------ > .../prog/en/modules/patroncards/edit-profile.tt | 31 ++------------------ > .../prog/en/modules/patroncards/edit-template.tt | 31 ++------------------ > 4 files changed, 6 insertions(+), 106 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >index 13fd05a..7a0811b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt >@@ -2,22 +2,6 @@ > <title>Koha › Tools › Patron card creator › Manage patron card batches</title> > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'greybox.inc' %] >- <script type="text/javascript"> >- //<![CDATA[ >- $(document).ready(function() { >- $("#cancel").empty(); >- buildButtons(); >- }); >- function buildButtons() { >- var cancelButton = new YAHOO.widget.Button({ >- type: "link", >- href: "/cgi-bin/koha/patroncards/manage.pl?card_element=batch", >- label: _("Cancel"), >- id: "cancel", >- container: "cancel", >- }); >- }; >- </script> > </head> > <body id="pcard_edit-batch" class="tools pcard"> > [% INCLUDE 'header.inc' %] >@@ -76,9 +60,6 @@ > </div> > [% END %] > </div> >- <fieldset class="action"> >- <span id="cancel"><a class="cancel" href="/cgi-bin/koha/patroncards/manage.pl?card_element=batch">Cancel</a></span> >- </fieldset> > </div> > </div> > <div class="yui-b"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >index 862a2fa..0a96568 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-layout.tt >@@ -105,33 +105,6 @@ > }); > //]]> > </script> >- <script type="text/javascript"> >- //<![CDATA[ >- $(document).ready(function() { >- $("#save").empty(); >- $("#cancel").empty(); >- buildButtons(); >- }); >- function submitForm() { >- document.input.submit(); >- }; >- function buildButtons() { >- var saveButton = new YAHOO.widget.Button({ >- type: "link", >- onclick: {fn: submitForm}, >- label: _("Save"), >- id: "save", >- container: "save" >- }); >- var cancelButton = new YAHOO.widget.Button({ >- type: "link", >- href: "/cgi-bin/koha/patroncards/manage.pl?card_element=layout", >- label: _("Cancel"), >- id: "cancel", >- container: "cancel", >- }); >- }; >- </script> > </head> > <body id="pcard_edit-layout" class="tools pcard"> > [% INCLUDE 'header.inc' %] >@@ -534,8 +507,8 @@ > </div> > </div> > <fieldset class="action"> >- <span id="save"><input type="submit" value="Save" /></span> >- <span id="cancel"><a class="cancel" href="/cgi-bin/koha/patroncards/manage.pl?card_element=layout">Cancel</a></span> >+ <input type="submit" value="Save" /> >+ <a class="cancel" href="/cgi-bin/koha/patroncards/manage.pl?card_element=layout">Cancel</a> > <input type="hidden" name="op" value="save" /> > <input type="hidden" name="layout_id" value="[% layout_id %]" /> > </fieldset> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt >index bf479ba..8f50488 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-profile.tt >@@ -35,33 +35,6 @@ > }); > //]]> > </script> >- <script type="text/javascript"> >- //<![CDATA[ >- $(document).ready(function() { >- $("#save").empty(); >- $("#cancel").empty(); >- buildButtons(); >- }); >- function submitForm() { >- document.input.submit(); >- }; >- function buildButtons() { >- var saveButton = new YAHOO.widget.Button({ >- type: "link", >- onclick: {fn: submitForm}, >- label: _("Save"), >- id: "save", >- container: "save" >- }); >- var cancelButton = new YAHOO.widget.Button({ >- type: "link", >- href: "/cgi-bin/koha/patroncards/manage.pl?card_element=profile", >- label: _("Cancel"), >- id: "cancel", >- container: "cancel", >- }); >- }; >- </script> > </head> > <body id="pcard_edit-profile" class="tools pcard"> > [% INCLUDE 'header.inc' %] >@@ -145,8 +118,8 @@ > </ol> > </fieldset> > <fieldset class="action"> >- <span id="save"><input type="submit" value="Save" /></span> >- <span id ="cancel"><a href="/cgi-bin/koha/patroncards/manage.pl?card_element=profile" class="cancel">Cancel</a></span> >+ <input type="submit" value="Save" /> >+ <a href="/cgi-bin/koha/patroncards/manage.pl?card_element=profile" class="cancel">Cancel</a> > <input type="hidden" name="op" value="save" /> > <input type="hidden" name="profile_id" value="[% profile_id %]" /> > </fieldset> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt >index b43f119..069161e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-template.tt >@@ -35,33 +35,6 @@ > }); > //]]> > </script> >- <script type="text/javascript"> >- //<![CDATA[ >- $(document).ready(function() { >- $("#save").empty(); >- $("#cancel").empty(); >- buildButtons(); >- }); >- function submitForm() { >- document.input.submit(); >- }; >- function buildButtons() { >- var saveButton = new YAHOO.widget.Button({ >- type: "link", >- onclick: {fn: submitForm}, >- label: _("Save"), >- id: "save", >- container: "save" >- }); >- var cancelButton = new YAHOO.widget.Button({ >- type: "link", >- href: "/cgi-bin/koha/patroncards/manage.pl?card_element=template", >- label: _("Cancel"), >- id: "cancel", >- container: "cancel", >- }); >- }; >- </script> > </head> > <body id="pcard_edit-template" class="tools pcard"> > [% INCLUDE 'header.inc' %] >@@ -181,8 +154,8 @@ > </div> > <div class="yui-g"> > <fieldset class="action"> >- <span id="save"><input type="submit" class="submit" value="Save" /></span> >- <span id="cancel"><a class="cancel" href="/cgi-bin/koha/patroncards/manage.pl?card_element=template">Cancel</a></span> >+ <input type="submit" class="submit" value="Save" /> >+ <a class="cancel" href="/cgi-bin/koha/patroncards/manage.pl?card_element=template">Cancel</a> > <input type="hidden" name="op" value="save" /> > [% IF ( template_id ) %] > <input type="hidden" name="template_id" value="[% template_id %]" /> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9696
:
15622
|
15638
|
15872