Some buttons on the patron card creator's edit pages are styled using YUI: /cgi-bin/koha/patroncards/edit-batch.pl /cgi-bin/koha/patroncards/edit-layout.pl /cgi-bin/koha/patroncards/edit-profile.pl /cgi-bin/koha/patroncards/edit-template.pl Typically we don't apply special button styling to submit buttons, so to make these pages consistent with others in Koha I propose to remove YUI styling.
Created attachment 15622 [details] [review] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly.
Created attachment 15638 [details] [review] [SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Works and looks well. No errors. Note: It's true that edit batch has not a submit button, but on the other managed pages (layout, profile, template) cancel aborts editing and takes you to a list of objects (layout, etc.) Now if we selected the wrong batch, we need to click on left menu o back button (yay). Are we loosing a consistent interface? Just thinking.
Created attachment 15872 [details] [review] [PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages Submit and cancel buttons on patron card creator edit pages should not be styled differently than other submit and cancel controls. This patch removes YUI styling of these controls and makes them consistent with controls on other Koha pages. The "Cancel" button has been removed altogether from the batch edit page since there is not a corresponding submit button. To test, got to the patron card creator and edit a batch, a layout, a profile, and a template. Submit and cancel controls should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Works and looks well. No errors. Note: It's true that edit batch has not a submit button, but on the other managed pages (layout, profile, template) cancel aborts editing and takes you to a list of objects (layout, etc.) Now if we selected the wrong batch, we need to click on left menu o back button (yay). Are we loosing a consistent interface? Just thinking. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, more consistent with Koha's general interface patterns.
This patch has been pushed to master.