Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages
Summary: Remove YUI styling from buttons on patron card creator edit pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/patroncards/edit-*.pl
Keywords:
Depends on:
Blocks: 9697
  Show dependency treegraph
 
Reported: 2013-02-22 14:51 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages (9.14 KB, patch)
2013-02-22 14:55 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages (9.56 KB, patch)
2013-02-22 19:58 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages (9.69 KB, patch)
2013-03-05 07:07 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-22 14:51:05 UTC
Some buttons on the patron card creator's edit pages are styled using YUI:

/cgi-bin/koha/patroncards/edit-batch.pl
/cgi-bin/koha/patroncards/edit-layout.pl
/cgi-bin/koha/patroncards/edit-profile.pl
/cgi-bin/koha/patroncards/edit-template.pl

Typically we don't apply special button styling to submit buttons, so to make these pages consistent with others in Koha I propose to remove YUI styling.
Comment 1 Owen Leonard 2013-02-22 14:55:17 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-22 19:58:41 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-05 07:07:25 UTC
Created attachment 15872 [details] [review]
[PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages

Submit and cancel buttons on patron card creator edit pages should not
be styled differently than other submit and cancel controls.

This patch removes YUI styling of these controls and makes them
consistent with controls on other Koha pages. The "Cancel" button has
been removed altogether from the batch edit page since there is not a
corresponding submit button.

To test, got to the patron card creator and edit a batch, a layout, a
profile, and a template. Submit and cancel controls should look correct
and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. Works and looks well. No errors.

Note: It's true that edit batch has not a submit button, but
on the other managed pages (layout, profile, template) cancel
aborts editing and takes you to a list of objects (layout, etc.)
Now if we selected the wrong batch, we need to click on left menu o
back button (yay). Are we loosing a consistent interface?
Just thinking.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, more consistent with Koha's general interface
patterns.
Comment 4 Jared Camins-Esakov 2013-03-07 14:55:34 UTC
This patch has been pushed to master.