Bugzilla – Attachment 15699 Details for
Bug 9444
Use DataTables in system preferences editor
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9444 [Revised] Use DataTables in system preferences editor
Bug-9444-Revised-Use-DataTables-in-system-preferen.patch (text/plain), 2.66 KB, created by
Owen Leonard
on 2013-02-26 16:21:31 UTC
(
hide
)
Description:
Bug 9444 [Revised] Use DataTables in system preferences editor
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-02-26 16:21:31 UTC
Size:
2.66 KB
patch
obsolete
>From 14f8bd1d40e71b85b27188e320a16248f84c61ea Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 22 Jan 2013 12:17:55 -0500 >Subject: [PATCH] Bug 9444 [Revised] Use DataTables in system preferences > editor >Content-Type: text/plain; charset="utf-8" > >Replace the tablesorter plugin with the DataTables plugin in the >"new" system preferences editor. > >To test, open the system preferences editor on any tab other than Local >Use. Confirm that table sorting works correctly within each section. In >this configuration there should be no pager and no results filtering. > >Revision corrects template path to datatables assets. >--- > .../intranet-tmpl/prog/en/js/pages/preferences.js | 11 +++++++---- > .../prog/en/modules/admin/preferences.tt | 5 ++++- > 2 files changed, 11 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >index 4d793a1..57f8dd3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >@@ -1,8 +1,11 @@ > $(document).ready(function() { >- $("table.preferences").tablesorter({ >- sortList: [[0,0]], >- headers: { 1: { sorter:false}} >- }); >+ $("table.preferences").dataTable($.extend(true, {}, dataTablesDefaults, { >+ "sDom": 't', >+ "aoColumnDefs": [ >+ { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false } >+ ], >+ "bPaginate": false >+ })); > }); > > // We can assume 'KOHA' exists, as we depend on KOHA.AJAX >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index 5b20399..ebb9d8c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -1,7 +1,10 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Administration › System preferences</title> > [% INCLUDE 'doc-head-close.inc' %] >-<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script> >+<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> >+<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> >+[% INCLUDE 'datatables-strings.inc' %] >+<script type="text/javascript" src="[% themelang %]/js/datatables.js"></script> > <link rel="stylesheet" type="text/css" href="[% themelang %]/css/preferences.css" /> > <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.fixFloat.js"></script> > <script type="text/javascript"> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9444
:
14754
|
14770
|
15699
|
15743
|
15811
|
15817
|
15841