The "new" system preferences editor uses the old tablesorter plugin. It should use the DataTables plugin instead.
Created attachment 14754 [details] [review] Bug 9444 - Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering.
Created attachment 14770 [details] [review] Bug 9444 - Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 15699 [details] [review] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets.
Created attachment 15743 [details] [review] [SIGNED-OFF] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors.
This patch breaks the collapse/expand action. The datatable plugin adds a div element around the table :-/ Marked as Failed QA.
Created attachment 15811 [details] [review] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS
Created attachment 15817 [details] [review] [SIGNED-OFF] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Collapsing restored. No errors.
QA comment: Now all work great. This patch add datatable on the syspref tables. The first column (syspref names) is sortable. Marked as Passed QA.
Created attachment 15841 [details] [review] Bug 9444 [Revised] Use DataTables in system preferences editor Replace the tablesorter plugin with the DataTables plugin in the "new" system preferences editor. To test, open the system preferences editor on any tab other than Local Use. Confirm that table sorting works correctly within each section. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Further revision fixes section-collapse JS Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. Collapsing restored. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.