Bugzilla – Attachment 160573 Details for
Bug 35489
Holds on items with no barcode are missing an input for itemnumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode
Bug-35489-2305x-Add-a-hidden-input-for-itemnumber-.patch (text/plain), 3.01 KB, created by
Nick Clemens (kidclamp)
on 2024-01-05 13:38:49 UTC
(
hide
)
Description:
Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2024-01-05 13:38:49 UTC
Size:
3.01 KB
patch
obsolete
>From 97e44b5968a4c1535adf405214990fc15653640f Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 5 Dec 2023 15:47:23 +0000 >Subject: [PATCH] Bug 35489: [23.05.x] Add a hidden input for itemnumber even > if item has no barcode > >This page is a single form, all fields must have inputs to avoid data loss/mismatch > >To test: >1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without >2 - Place an item level hold on the item with no barcode >3 - Place another hold for a different patron on the item with a barcode >4 - From the holds table add an expiration date to the hold with a barcode and save >5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold >6 - Delete the holds >7 - Apply patch >8 - Repeat 2-4 >9 - Confirm the itemnumbers for the holds have not changed > >Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >index 24905d7d243..e17a73b0246 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc >@@ -169,10 +169,10 @@ > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> > [%- IF ( hold.barcodenumber ) -%] > [%- hold.barcodenumber | html -%] >- <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> > [%- ELSE -%] > <span>No barcode</span> > [%- END -%] >+ <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> > </a> > [%- ELSE -%] > [%- IF ( hold.item_level_hold ) -%] >@@ -181,10 +181,10 @@ > <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% hold.biblionumber | uri %]&itemnumber=[% hold.itemnumber | uri %]#item[% hold.itemnumber | uri %]"> > [%- IF ( hold.barcodenumber ) -%] > [%- hold.barcodenumber | html -%] >- <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> > [%- ELSE -%] > <span>No barcode</span> > [%- END -%] >+ <input type="hidden" name="itemnumber" value="[% hold.itemnumber | html %]" /> > </a> > </em> > [%- ELSE -%] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35489
:
159588
|
159607
|
159929
| 160573