Bug 35489 - Holds on items with no barcode are missing an input for itemnumber
Summary: Holds on items with no barcode are missing an input for itemnumber
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-05 15:47 UTC by Nick Clemens (kidclamp)
Modified: 2024-01-12 14:44 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 35489: Add a hidden input for itemnumber even if item has no barcode (2.90 KB, patch)
2023-12-05 15:50 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 35489: (2.95 KB, patch)
2023-12-05 19:38 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35489: Add a hidden input for itemnumber even if item has no barcode (3.07 KB, patch)
2023-12-16 23:55 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode (3.01 KB, patch)
2024-01-05 13:38 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-12-05 15:47:01 UTC
This causes a move/loss of data on the holds form (request.pl) when holds are adjusted

To test:
1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without
2 - Place an item level hold on the item with no barcode
3 - Place another hold for a different patron on the item with a barcode
4 - From the holds table add an expiration date to the hold with a barcode and save
5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold
Comment 1 Nick Clemens (kidclamp) 2023-12-05 15:50:52 UTC
Created attachment 159588 [details] [review]
Bug 35489: Add a hidden input for itemnumber even if item has no barcode

This page is a single form, all fields must have inputs to avoid data loss/mismatch

To test:
1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without
2 - Place an item level hold on the item with no barcode
3 - Place another hold for a different patron on the item with a barcode
4 - From the holds table add an expiration date to the hold with a barcode and save
5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold
6 - Delete the holds
7 - Apply patch
8 - Repeat 2-4
9 - Confirm the itemnumbers for the holds have not changed
Comment 2 ByWater Sandboxes 2023-12-05 19:38:43 UTC
Created attachment 159607 [details] [review]
Bug 35489:

This page is a ingle form, all fields must have inputs to avoid data loss/mismatch

To test:
1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without
2 - Place an item level hold on the item with no barcode
3 - Place another hold for a different patron on the item with a barcode
4 - From the holds table add an expiration date to the hold with a barcode and save
5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold
6 - Delete the holds
7 - Apply patch
8 - Repeat 2-4
9 - Confirm the itemnumbers for the holds have not changed

Signed-off-by: Andrew  Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Andrew Fuerste-Henry 2023-12-05 19:40:27 UTC
The sandbox seems to have done something weird to the attachments on this bug, but it was my intent to sign off.
Comment 4 Victor Grousset/tuxayo 2023-12-16 23:55:48 UTC
Created attachment 159929 [details] [review]
Bug 35489: Add a hidden input for itemnumber even if item has no barcode

This page is a single form, all fields must have inputs to avoid data loss/mismatch

To test:
1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without
2 - Place an item level hold on the item with no barcode
3 - Place another hold for a different patron on the item with a barcode
4 - From the holds table add an expiration date to the hold with a barcode and save
5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold
6 - Delete the holds
7 - Apply patch
8 - Repeat 2-4
9 - Confirm the itemnumbers for the holds have not changed

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 5 Victor Grousset/tuxayo 2023-12-16 23:57:35 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 6 Katrin Fischer 2023-12-18 14:25:33 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 14:49:57 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass 2024-01-04 20:23:04 UTC
Please rebase this for 23.05.x if needed.
Comment 9 Nick Clemens (kidclamp) 2024-01-05 13:38:49 UTC
Created attachment 160573 [details] [review]
Bug 35489: [23.05.x] Add a hidden input for itemnumber even if item has no barcode

This page is a single form, all fields must have inputs to avoid data loss/mismatch

To test:
1 - Find a record in the catalog and add or edit items to have one item with a barcode and one without
2 - Place an item level hold on the item with no barcode
3 - Place another hold for a different patron on the item with a barcode
4 - From the holds table add an expiration date to the hold with a barcode and save
5 - Note the hold on the item with no barcode is now on the item with a barcode and the other hold is now a next available hold
6 - Delete the holds
7 - Apply patch
8 - Repeat 2-4
9 - Confirm the itemnumbers for the holds have not changed

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 10 Lucas Gass 2024-01-12 14:44:00 UTC
Backported to 23.05.x for upcoming 23.05.08.