Bugzilla – Attachment 18103 Details for
Bug 10230
Match points do not work with authorities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10230: show correct matching record
Bug-10230-show-correct-matching-record.patch (text/plain), 2.99 KB, created by
Jared Camins-Esakov
on 2013-05-12 20:27:02 UTC
(
hide
)
Description:
Bug 10230: show correct matching record
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2013-05-12 20:27:02 UTC
Size:
2.99 KB
patch
obsolete
>From 59213f029a561e4e49bb9fa05e6af8c9ce9b4801 Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Sat, 11 May 2013 16:07:43 -0400 >Subject: [PATCH] Bug 10230: show correct matching record > >The correct matching record was not always shown on the manage staged >MARC page. This patch corrects the issue and provides the template with >the appropriate ID for the matched record regardless what type of record >it is. > >To test: >1) Create a matching record for authorities. For MARC21, the following > is a good choice: > Matching rule code: AUTHPER > Description: Personal name main entry > Match threshold: 999 > Record type: Authority record > [Match point 1:] > Search index: mainmainentry > Score: 1000 > Tag: 100 > Subfields: a >2) Create a record that has the appropriate fields for being matched > with that rule (if you don't already have one). >3) Save the authority record as MARC (Unicode/UTF-8). >4) Stage the file choosing your new matching rule. >5) Note that with these patches, you get a link to the existing > authority and without them you could get any number of strange > things. >--- > tools/manage-marc-import.pl | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl >index 32d3645..25f7769 100755 >--- a/tools/manage-marc-import.pl >+++ b/tools/manage-marc-import.pl >@@ -365,12 +365,17 @@ sub import_records_list { > > my $match = GetImportRecordMatches($record->{'import_record_id'}, 1); > my $match_citation = ''; >+ my $match_id; > if ($#$match > -1) { > if ($match->[0]->{'record_type'} eq 'biblio') { > $match_citation .= $match->[0]->{'title'} if defined($match->[0]->{'title'}); > $match_citation .= ' ' . $match->[0]->{'author'} if defined($match->[0]->{'author'}); >+ $match_id = $match->[0]->{'biblionumber'}; > } elsif ($match->[0]->{'record_type'} eq 'auth') { >- $match_citation .= $match->[0]->{'authorized_heading'} if defined($match->[0]->{'authorized_heading'}); >+ if (defined($match->[0]->{'authorized_heading'})) { >+ $match_citation .= $match->[0]->{'authorized_heading'}; >+ $match_id = $match->[0]->{'candidate_match_id'}; >+ } > } > } > >@@ -383,7 +388,7 @@ sub import_records_list { > overlay_status => $record->{'overlay_status'}, > # Sorry about the match_id being from the "biblionumber" field; > # as it turns out, any match id will go in biblionumber >- match_id => $#$match > -1 ? $match->[0]->{'biblionumber'} : 0, >+ match_id => $match_id, > match_citation => $match_citation, > match_score => $#$match > -1 ? $match->[0]->{'score'} : 0, > record_type => $record->{'record_type'}, >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10230
:
18101
|
18102
|
18103
|
18231
|
18232
|
18233