Bug 10230 - Match points do not work with authorities
Summary: Match points do not work with authorities
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Authority data support (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-11 18:39 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:09 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10230: no need to use SimpleSearch for matching auths (4.66 KB, patch)
2013-05-12 20:26 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10230: Don't limit valid matches to bibs (1.93 KB, patch)
2013-05-12 20:26 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10230: show correct matching record (2.99 KB, patch)
2013-05-12 20:27 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
[PASSED QA] Bug 10230: no need to use SimpleSearch for matching auths (4.76 KB, patch)
2013-05-18 21:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10230: Don't limit valid matches to bibs (2.03 KB, patch)
2013-05-18 21:24 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10230: show correct matching record (3.29 KB, patch)
2013-05-18 21:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-05-11 18:39:41 UTC
Some of the changes in 3.12 cause problems with matching when importing authorities. Individual descriptions on each patch, and test plan on the last.
Comment 1 Jared Camins-Esakov 2013-05-12 20:26:34 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2013-05-12 20:26:46 UTC Comment hidden (obsolete)
Comment 3 Jared Camins-Esakov 2013-05-12 20:27:02 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-05-18 21:24:29 UTC
Created attachment 18231 [details] [review]
[PASSED QA] Bug 10230: no need to use SimpleSearch for matching auths

When introducing QueryParser, I introduced a check for QueryParser at
too high a level, causing authority matching to try and use SimpleSearch
for authorities prematurely, when SearchAuthorities should be handling
it. This patch corrects the level of the check. This patch only moves
three lines, but thanks to the change in if level, it adjusts the
indentation quite a bit.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on third patch of this series.
Comment 5 Katrin Fischer 2013-05-18 21:24:47 UTC
Created attachment 18232 [details] [review]
[PASSED QA] Bug 10230: Don't limit valid matches to bibs

The patch for bug 9523 added a JOIN to the biblio table when identifying
the best match so that if a matched record had been deleted it would
not hold up the import process. Unfortunately, this broke all authority
matching, since of course authorities don't appear in the biblio table.
This patch adds a join to auth_header as well, and decides which to
check based on the record type.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment on third patch of this series.
Comment 6 Katrin Fischer 2013-05-18 21:24:56 UTC
Created attachment 18233 [details] [review]
[PASSED QA] Bug 10230: show correct matching record

The correct matching record was not always shown on the manage staged
MARC page. This patch corrects the issue and provides the template with
the appropriate ID for the matched record regardless what type of record
it is.

To test:
1) Create a matching record for authorities. For MARC21, the following
   is a good choice:
   Matching rule code:  AUTHPER
   Description:         Personal name main entry
   Match threshold:     999
   Record type:         Authority record
   [Match point 1:]
    Search index:   mainmainentry
    Score:          1000
    Tag:            100
    Subfields:      a
2) Create a record that has the appropriate fields for being matched
   with that rule (if you don't already have one).
3) Save the authority record as MARC (Unicode/UTF-8).
4) Stage the file choosing your new matching rule.
5) Note that with these patches, you get a link to the existing
   authority and without them you could get any number of strange
   things.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script. Additional tests done:
- staged bibliographic records and matched with different
  rules and actions. Undid the import.
- staged autohrity recods and matched with the example rule.
  Undid the import.
Comment 7 Jared Camins-Esakov 2013-05-19 12:41:38 UTC
This patch has been pushed to master and 3.12.x.