Bugzilla – Attachment 19026 Details for
Bug 10471
Global search input box and button geometry not always consistent (browsers, translations)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10471 - Global search input box and button geometry not always consistent
Bug-10471---Global-search-input-box-and-button-geo.patch (text/plain), 7.59 KB, created by
Tomás Cohen Arazi
on 2013-06-14 18:47:30 UTC
(
hide
)
Description:
Bug 10471 - Global search input box and button geometry not always consistent
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2013-06-14 18:47:30 UTC
Size:
7.59 KB
patch
obsolete
>From ccaac4d269e8b29db6498fb191c5c696ed0a08f2 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Fri, 14 Jun 2013 15:37:00 -0300 >Subject: [PATCH] Bug 10471 - Global search input box and button geometry not > always consistent >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch reorders the submit input object from the related templates and >wraps the text input box inside a span. This way the span geometry is calculated >with the submit input object there, to fill the rest of the div. > >CSS are adjusted so everything looks like before. > >I'm by no means expert in UI design so I know this might be far from perfect. I expect this >to serve as a discussion for a proper solution that could be provided as followups if needed. > >Waiting for your comments! >To+ > >Sponsored-by: Universidad Nacional de Córdoba >--- > .../intranet-tmpl/prog/en/css/staff-global.css | 27 ++++++++++++++- > .../intranet-tmpl/prog/en/includes/circ-search.inc | 4 +-- > .../intranet-tmpl/prog/en/includes/home-search.inc | 6 ++-- > .../prog/en/includes/patron-search-box.inc | 35 ++++++++++---------- > 4 files changed, 48 insertions(+), 24 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >index 3439e23..7b1bec5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css >@@ -2567,4 +2567,29 @@ fieldset.rows table.mceListBox { > font-size: 140%; > font-family : monospace; > padding : .3em; >-} >\ No newline at end of file >+} >+ >+.residentsearch { >+ overflow: hidden; >+} >+ >+.residentsearch > form > span > input[type='text'] { >+ width: 100%; >+ padding-top: 0px; >+ padding-right: 0px; >+ padding-bottom: 3px; >+ padding-left: 0px; >+} >+ >+.residentsearch > form > span { >+ display: block; >+ overflow: hidden; >+ padding-top: 0px; >+ padding-right: 5px; >+ padding-bottom: 3px; >+ height: 24px; >+} >+ >+.residentsearch > form > input[type='submit'] { >+ float: right; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc >index 5a145c6..773cac9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/circ-search.inc >@@ -7,16 +7,16 @@ > <div id="checkin_search" class="residentsearch"> > <p class="tip">Scan a barcode to check in:</p> > <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> >- <input name="barcode" id="ret_barcode" size="40" accesskey="r" /> > <input value="Submit" class="submit" type="submit" /> >+ <span><input type="text" name="barcode" id="ret_barcode" size="40" accesskey="r" /></span> > </form> > </div>[% END %] > [% IF ( CAN_user_catalogue ) %] > <div id="catalog_search" class="residentsearch"> > <p class="tip">Enter search keywords:</p> > <form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block"> >- <input type="text" name="q" id="search-form" size="40" accesskey="q" /> > <input type="submit" class="submit" value="Submit"/> >+ <span><input type="text" name="q" id="search-form" size="40" accesskey="q" /></span> > </form> > </div>[% END %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc >index 46d8b45..cdbc81e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/home-search.inc >@@ -7,24 +7,24 @@ > <div id="checkin_search" class="residentsearch"> > <p class="tip">Scan a barcode to check in:</p> > <form method="post" action="/cgi-bin/koha/circ/returns.pl" autocomplete="off"> >- <input name="barcode" id="ret_barcode" size="40" accesskey="r" /> > <input value="Submit" class="submit" type="submit" /> >+ <span><input type="text" name="barcode" id="ret_barcode" size="40" accesskey="r" /></span> > </form> > </div>[% END %] > [% IF ( CAN_user_borrowers ) %] > <div id="patron_search" class="residentsearch"> > <p class="tip">Enter patron card number or partial name:</p> > <form action="/cgi-bin/koha/members/member.pl" method="post"> >- <input name="member" id="searchmember" size="40" type="text"/> > <input value="Submit" class="submit" type="submit" /> >+ <span><input type="text" name="member" id="searchmember" size="40" /></span> > </form> > </div>[% END %] > [% IF ( CAN_user_catalogue ) %] > <div id="catalog_search" class="residentsearch"> > <p class="tip">Enter search keywords:</p> > <form action="/cgi-bin/koha/catalogue/search.pl" method="get" id="cat-search-block"> >- <input type="text" name="q" id="search-form" size="40" accesskey="q" /> > <input type="submit" class="submit" value="Submit"/> >+ <span><input type="text" name="q" id="search-form" size="40" accesskey="q" /></span> > </form> > </div>[% END %] > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc >index 388c467..4a7437a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc >@@ -21,28 +21,27 @@ $(document).ready(function(){ > //]]> > </script>[% END %] > <div id="circ_search" class="residentsearch"> >- <p class="tip">Enter patron card number or partial name:</p> >- <form action="/cgi-bin/koha/circ/circulation.pl" id="patronsearch" method="post"> >+ <p class="tip">Enter patron card number or partial name:</p> >+ <form action="/cgi-bin/koha/circ/circulation.pl" id="patronsearch" method="post"> > [% IF ( CircAutocompl ) %] >- <div class="autocomplete"> >- <input autocomplete="off" id="findborrower" name="findborrower" size="40" class="focus" type="text" /> <input id="autocsubmit" type="submit" class="submit" value="Submit" /> >- <input name="branch" value="[% branch %]" type="hidden" /> >- <input name="printer" value="" type="hidden" /> >- [% IF ( stickyduedate ) %] >- <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> >- <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" /> >- [% END %] >- </div> >- [% ELSE %] >+ <input id="autocsubmit" type="submit" class="submit" value="Submit"/> >+ <span><input autocomplete="off" id="findborrower" name="findborrower" size="40" class="focus" type="text" /></span> >+ <input name="branch" value="[% branch %]" type="hidden" /> >+ <input name="printer" value="" type="hidden" /> >+ [% IF ( stickyduedate ) %] >+ <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> >+ <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" /> >+ [% END %] >+ [% ELSE %] > <input id="findborrower" name="findborrower" size="40" class="focus" type="text" /> > <input name="branch" value="[% branch %]" type="hidden" /> > <input name="printer" value="" type="hidden" /> >- [% IF ( stickyduedate ) %] >+ [% IF ( stickyduedate ) %] > <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> > <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" /> >- [% END %] >+ [% END %] > <input value="Submit" class="submit" type="submit" /> >- [% END %] >- </form> >- </div> >- [% END %] >+ [% END %] >+ </form> >+ </div> >+[% END %] >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10471
:
19023
|
19024
| 19026