Bug 10471 - Global search input box and button geometry not always consistent (browsers, translations)
Summary: Global search input box and button geometry not always consistent (browsers, ...
Status: RESOLVED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-14 18:35 UTC by Tomás Cohen Arazi
Modified: 2023-07-08 16:12 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Firefox snapshot (126.53 KB, image/png)
2013-06-14 18:40 UTC, Tomás Cohen Arazi
Details
Chrome snapshot (123.07 KB, image/png)
2013-06-14 18:40 UTC, Tomás Cohen Arazi
Details
Bug 10471 - Global search input box and button geometry not always consistent (7.59 KB, patch)
2013-06-14 18:47 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-06-14 18:35:17 UTC

    
Comment 1 Tomás Cohen Arazi 2013-06-14 18:40:24 UTC
Created attachment 19023 [details]
Firefox snapshot
Comment 2 Tomás Cohen Arazi 2013-06-14 18:40:47 UTC
Created attachment 19024 [details]
Chrome snapshot
Comment 3 Tomás Cohen Arazi 2013-06-14 18:47:30 UTC
Created attachment 19026 [details] [review]
Bug 10471 - Global search input box and button geometry not always consistent

This patch reorders the submit input object from the related templates and
wraps the text input box inside a span. This way the span geometry is calculated
with the submit input object there, to fill the rest of the div.

CSS are adjusted so everything looks like before.

I'm by no means expert in UI design so I know this might be far from perfect. I expect this
to serve as a discussion for a proper solution that could be provided as followups if needed.

Waiting for your comments!
To+

Sponsored-by: Universidad Nacional de Córdoba
Comment 4 Tomás Cohen Arazi 2013-06-14 18:56:03 UTC
To test:
- Take a look at the way every tab in the staff client's global search looks [1]
  * In circulation
  * At any other admin page
- Apply the patch
- Take a look at how they look, it should look slightly better (search box occupies the whole space, and the button lays on the very right side).

Note: The best solution should copmlement this, and calculate the biggest size of the whole div and fix all into it.

[1] Those two have different templates to render the search box and tabs.
Comment 5 Marc Véron 2016-10-03 15:34:33 UTC
Still valid?
Comment 6 Katrin Fischer 2023-07-08 16:12:22 UTC
I believe that this is no longer valid with the staff interface redesign.