Bugzilla – Attachment 23056 Details for
Bug 11207
Impossibility to remove a sms number
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11207: No way to remove a sms alert number
PASSED-QA-Bug-11207-No-way-to-remove-a-sms-alert-n.patch (text/plain), 1.67 KB, created by
Katrin Fischer
on 2013-11-20 21:47:16 UTC
(
hide
)
Description:
[PASSED QA] Bug 11207: No way to remove a sms alert number
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-11-20 21:47:16 UTC
Size:
1.67 KB
patch
obsolete
>From 5353fedcb44c7324e74534f169e94dc4230d30cd Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 6 Nov 2013 12:33:59 +0100 >Subject: [PATCH] [PASSED QA] Bug 11207: No way to remove a sms alert number > >Test plan: >1/ edit a patron >2/ set a sms alert number >3/ save >4/ edit the patron >5/ set the sms alert number to a blank value >6/ save >7/ the sms number is now an empty string > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script. > >Test plan used: >- Activate the SMS functionality by giving a 'fake' > SMSSendDriver of TEST >- Activate EnhancedMessagingPreferences >- Create a new patron, set Other phone to 'test' >- Notice that Other phone was copied to sms number >- Edit messaging preference section using the edit link > below on the details tab and delete SMS number >- Verify it's not possible to unset the SMS number >- Apply patch >- Repeat deleting - this time it works >--- > members/memberentry.pl | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index e7f07a9..0d3a3c3 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -348,7 +348,13 @@ if ( ($op eq 'modify' || $op eq 'insert' || $op eq 'save'|| $op eq 'duplicate') > } > } > >-if ( ( defined $input->param('SMSnumber') ) && ( $input->param('SMSnumber') ne $newdata{'mobile'} ) ) { >+if ( >+ defined $input->param('SMSnumber') >+ && ( >+ $input->param('SMSnumber') eq "" >+ or $input->param('SMSnumber') ne $newdata{'mobile'} >+ ) >+) { > $newdata{smsalertnumber} = $input->param('SMSnumber'); > } > >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11207
:
22748
|
22935
| 23056