Bug 11207 - Impossibility to remove a sms number
Summary: Impossibility to remove a sms number
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-06 11:33 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11207: No way to remove a sms alert number (1.09 KB, patch)
2013-11-06 11:35 UTC, Jonathan Druart 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11207: No way to remove a sms alert number (1.20 KB, patch)
2013-11-14 15:42 UTC, Owen Leonard 		Details | Diff | Splinter Review
[PASSED QA] Bug 11207: No way to remove a sms alert number (1.67 KB, patch)
2013-11-20 21:47 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-11-06 11:33:47 UTC 
To reproduce:
1/ edit a patron
2/ set a sms alert number
3/ save
4/ edit the patron
5/ try to remove the sms alert number
Comment 1 Jonathan Druart 2013-11-06 11:35:13 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-11-06 11:38:45 UTC 
Note: I don't understand the other test
  $input->param('SMSnumber') ne $newdata{'mobile'}
Comment 3 Owen Leonard 2013-11-14 15:42:36 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-11-19 21:41:15 UTC 
I am sorry, but I can't reproduce the problem on current master.

I have
- activated the SMS functionality by giving a 'fake' SMSSendDriver of TEST
- activated EnhancedMessagingPreferences
- created a new patron, set sms number to 'test'
- edited the patron and deleted 'test'
- after saving it's gone and deleted from the database
Comment 5 Jonathan Druart 2013-11-20 08:17:15 UTC 
Katrin, I forgot something:
If you edit the patron, the mobile number (other phone) has to be empty. If you fill it, you can delete the sms number.
The bug is always reproducible on editing the step 5 (messaging pref) only: /members/memberentry.pl?op=modify&borrowernumber=XXXX&step=5
Comment 6 Katrin Fischer 2013-11-20 08:31:05 UTC 
Hi Jonathan,
I created a new patron so I am sure mobile was empty and I think I used the link on the page to only edit the prefs and not the 'full' patron - but I will give it another try.
Comment 7 Katrin Fischer 2013-11-20 21:47:16 UTC 
Created attachment 23056 [details] [review]
[PASSED QA] Bug 11207: No way to remove a sms alert number

Test plan:
1/ edit a patron
2/ set a sms alert number
3/ save
4/ edit the patron
5/ set the sms alert number to a blank value
6/ save
7/ the sms number is now an empty string

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

Test plan used:
- Activate the SMS functionality by giving a 'fake'
  SMSSendDriver of TEST
- Activate EnhancedMessagingPreferences
- Create a new patron, set Other phone to 'test'
- Notice that Other phone was copied to sms number
- Edit messaging preference section using the edit link
  below on the details tab and delete SMS number
- Verify it's not possible to unset the SMS number
- Apply patch
- Repeat deleting - this time it works
Comment 8 Galen Charlton 2013-11-21 15:17:16 UTC 
Pushed to master.  Thanks, Jonathan!
Comment 9 Fridolin Somers 2013-12-13 07:31:02 UTC 
This patch has been pushed to 3.14.x, will be in 3.14.1