Bugzilla – Attachment 23858 Details for
Bug 11131
Authority search does not display summary while searching by all auth types
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types
PASSED-QA-Bug-11131-Authority-search-does-not-disp.patch (text/plain), 1.67 KB, created by
Katrin Fischer
on 2013-12-29 08:54:47 UTC
(
hide
)
Description:
[PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-12-29 08:54:47 UTC
Size:
1.67 KB
patch
obsolete
>From 3efef74085b5e44ce820936b31696bd98d5b7e73 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Thu, 24 Oct 2013 15:28:42 +0200 >Subject: [PATCH] [PASSED QA] Bug 11131: Authority search does not display > summary while searching by all auth types > >The summary is built using the authtypecode selected from the interface. >So when a search is launch on all auth types, the summary is not >correctly built by the BuildSummary routine. >It should get the authtypecode from the authority (call to >GetAuthTypeCode). > >To test: >1/ go to authorities/authorities-home.pl >2/ search <something> by authtype personal name >3/ results are displayed with summary >4/ now select the default entry and search again the >results display but without the summary >5/ apply the patch >6/ search default again, now summary shows > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Tested with a UNIMARC database, works as described. >All tests and QA script pass. >--- > C4/AuthoritiesMarc.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm >index 7443f36..a22190b 100644 >--- a/C4/AuthoritiesMarc.pm >+++ b/C4/AuthoritiesMarc.pm >@@ -275,7 +275,7 @@ sub SearchAuthorities { > $newline{authid} = $authid; > if ( !$skipmetadata ) { > my $summary = >- BuildSummary( $authrecord, $authid, $authtypecode ); >+ BuildSummary( $authrecord, $authid, GetAuthTypeCode($authid) ); > my $query_auth_tag = > "SELECT auth_tag_to_report FROM auth_types WHERE authtypecode=?"; > my $sth = $dbh->prepare($query_auth_tag); >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11131
:
22358
|
23840
| 23858