Bug 11131 - Authority search does not display summary while searching by all auth types
Summary: Authority search does not display summary while searching by all auth types
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-24 13:28 UTC by Jonathan Druart
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11131: Authority search does not display summary while searching by all auth types (1.19 KB, patch)
2013-10-24 13:34 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11131: Authority search does not display summary while searching by all auth types (1.52 KB, patch)
2013-12-28 04:37 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types (1.67 KB, patch)
2013-12-29 08:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-10-24 13:28:25 UTC
To reproduce:
- go on authorities/authorities-home.pl
- search 'hugo' by authtype author
- results are displayed with summary
- now select the "all authority types" entry and search "hugo": the results but without the summary
Comment 1 Jonathan Druart 2013-10-24 13:34:17 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-11-07 08:14:44 UTC
testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d')

 [1;32mOK[0m	C4/AuthoritiesMarc.pm
Comment 3 Chris Cormack 2013-12-28 04:37:52 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-12-29 08:54:47 UTC
Created attachment 23858 [details] [review]
[PASSED QA] Bug 11131: Authority search does not display summary while searching by all auth types

The summary is built using the authtypecode selected from the interface.
So when a search is launch on all auth types, the summary is not
correctly built by the BuildSummary routine.
It should get the authtypecode from the authority (call to
GetAuthTypeCode).

To test:
1/ go to authorities/authorities-home.pl
2/ search <something> by authtype personal name
3/ results are displayed with summary
4/ now select the default entry and search again the
results display but without the summary
5/ apply the patch
6/ search default again, now summary shows

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with a UNIMARC database, works as described.
All tests and QA script pass.
Comment 5 Galen Charlton 2013-12-30 19:12:52 UTC
Pushed to master.  Thanks, Jonathan!
Comment 6 Fridolin Somers 2014-01-27 13:50:52 UTC
Patch pushed to 3.14.x, will be in 3.14.3.