Bugzilla – Attachment 25050 Details for
Bug 11670
Remove sorting from patron lists action columns
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11670 - Remove sorting from patron lists action columns
Bug-11670---Remove-sorting-from-patron-lists-actio.patch (text/plain), 3.31 KB, created by
Petter Goksøyr Åsen
on 2014-02-05 12:32:16 UTC
(
hide
)
Description:
Bug 11670 - Remove sorting from patron lists action columns
Filename:
MIME Type:
Creator:
Petter Goksøyr Åsen
Created:
2014-02-05 12:32:16 UTC
Size:
3.31 KB
patch
obsolete
>From 37395dc9df7b599786a3190d6e5d4e44fc3f47ba Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 3 Feb 2014 12:03:14 -0500 >Subject: [PATCH] Bug 11670 - Remove sorting from patron lists action columns > >The list of patron lists has sortable columns for the add, edit, and >delete buttons. These columns should not be sortable. This patch removes >sorting. > >This patch also adds the "btn-mini" class to the in-table buttons to >make the table more compact. > >To test you must have existing patron lists. Apply the patch and >navigate to Tools -> Patron lists. The columns containing the add, edit, >and delete buttons should not be sortable. Other columns should sort >correctly. > >--------------------------------------------------------------------- > >Created to patron lists and confirmed the collums 'add patrons', 'edit' >and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list' >are still sortable. The size of buttons are smaller. >I also agree this is an improvement. > >Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com> >--- > .../intranet-tmpl/prog/en/modules/patron_lists/lists.tt | 12 ++++++++---- > 1 fil ändrad, 8 tillägg(+), 4 borttagningar(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt >index 901b925..ec8c2b4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt >@@ -8,7 +8,11 @@ > <script type="text/javascript"> > //<![CDATA[ > $(document).ready(function() { >- $('#patron-lists-table').dataTable($.extend(true, {}, dataTablesDefaults)); >+ $('#patron-lists-table').dataTable($.extend(true, {}, dataTablesDefaults, { >+ "aoColumnDefs": [ >+ { "aTargets": [ -1, -2, -3 ], "bSortable": false, "bSearchable": false }, >+ ] >+ } )); > }); > > function ConfirmDelete( list ) { >@@ -49,17 +53,17 @@ > <td>[% l.name %]</td> > <td>[% l.patron_list_patrons.size || 0 %]</td> > <td> >- <a class="btn" href="list.pl?patron_list_id=[% l.patron_list_id %]"> >+ <a class="btn btn-mini" href="list.pl?patron_list_id=[% l.patron_list_id %]"> > <i class="icon-plus-sign"></i> Add patrons <i class="icon-user"></i> > </a> > </td> > <td> >- <a class="btn" href="add-modify.pl?patron_list_id=[% l.patron_list_id %]"> >+ <a class="btn btn-mini" href="add-modify.pl?patron_list_id=[% l.patron_list_id %]"> > <i class="icon-edit"></i> Edit > </a> > </td> > <td> >- <a class="btn" href="delete.pl?patron_list_id=[% l.patron_list_id %]" onclick='return ConfirmDelete("[% l.name | html %]")'> >+ <a class="btn btn-mini" href="delete.pl?patron_list_id=[% l.patron_list_id %]" onclick='return ConfirmDelete("[% l.name | html %]")'> > <i class="icon-trash"></i> Delete > </a> > </td> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11670
:
25009
|
25050
|
25136