Bug 11670 - Remove sorting from patron lists action columns
Summary: Remove sorting from patron lists action columns
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-03 16:57 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11670 - Remove sorting from patron lists action columns (2.97 KB, patch)
2014-02-03 17:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11670 - Remove sorting from patron lists action columns (3.31 KB, patch)
2014-02-05 12:32 UTC, Petter Goksøyr Åsen
Details | Diff | Splinter Review
Bug 11670 - Remove sorting from patron lists action columns (3.36 KB, patch)
2014-02-07 14:40 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-03 16:57:27 UTC
The table that lists patron lists has sortable columns for add, edit, and delete buttons. These columns should not be sortable.
Comment 1 Owen Leonard 2014-02-03 17:06:18 UTC Comment hidden (obsolete)
Comment 2 Petter Goksøyr Åsen 2014-02-05 12:32:16 UTC Comment hidden (obsolete)
Comment 3 Petter Goksøyr Åsen 2014-02-05 12:33:47 UTC
Sorry, a few typos there, should be
Created TWO patron lists and confirmed the COLUMNS ...
Comment 4 Kyle M Hall 2014-02-07 14:40:48 UTC
Created attachment 25136 [details] [review]
Bug 11670 - Remove sorting from patron lists action columns

The list of patron lists has sortable columns for the add, edit, and
delete buttons. These columns should not be sortable. This patch removes
sorting.

This patch also adds the "btn-mini" class to the in-table buttons to
make the table more compact.

To test you must have existing patron lists. Apply the patch and
navigate to Tools -> Patron lists. The columns containing the add, edit,
and delete buttons should not be sortable. Other columns should sort
correctly.

---------------------------------------------------------------------

Created to patron lists and confirmed the collums 'add patrons', 'edit'
and 'delete' are no longer sortable. Column 'Name' and 'Patrons in list'
are still sortable. The size of buttons are smaller.
I also agree this is an improvement.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Galen Charlton 2014-02-10 15:59:45 UTC
Pushed to master.  Thanks, Owen!
Comment 6 Fridolin Somers 2014-05-19 13:50:08 UTC
Pushed to 3.14.x, will be in 3.14.07.