Bugzilla – Attachment 2662 Details for
Bug 5265
error message on lists is misleading
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-5265-error-message-on-lists-is-misleadin.patch (text/plain), 1.27 KB, created by
Owen Leonard
on 2010-10-04 14:33:28 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2010-10-04 14:33:28 UTC
Size:
1.27 KB
patch
obsolete
>From bc249d442386d30360ec1c407ce2dc63fd4b5a94 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 4 Oct 2010 10:30:55 -0400 >Subject: [PATCH] Fix for Bug 5265, error message on lists is misleading > >The check to see if an item exists always evaluates as true. >Correcting this lets the script handle the error as it >was designed to. >--- > C4/VirtualShelves/Page.pm | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > >diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm >index 73ca42d..9d15847 100644 >--- a/C4/VirtualShelves/Page.pm >+++ b/C4/VirtualShelves/Page.pm >@@ -89,7 +89,8 @@ sub shelfpage ($$$$$) { > if ( $shelfnumber = $query->param('viewshelf') ) { > if ( ShelfPossibleAction( $loggedinuser, $shelfnumber, 'manage' ) ) { > if ( $barcode = $query->param('addbarcode') ) { >- if ( $item = GetItem( 0, $barcode ) ) { >+ $item = GetItem( 0, $barcode ); >+ if (defined $item && $item->{'itemnumber'}){ > $biblio = GetBiblioFromItemNumber( $item->{'itemnumber'} ); > AddToShelf( $biblio->{'biblionumber'}, $shelfnumber ) > or push @paramsloop, { duplicatebiblio => $barcode }; >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5265
:
2655
| 2662