Bug 5265 - error message on lists is misleading
Summary: error message on lists is misleading
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor
Assignee: Owen Leonard
QA Contact: Bugs List
URL: cgi-bin/koha/virtualshelves/shelves.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-29 17:06 UTC by Nicole C. Engard
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
error (13.75 KB, image/png)
2010-09-29 17:06 UTC, Nicole C. Engard
Details
Proposed fix (1.27 KB, patch)
2010-10-04 14:33 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-09-29 17:06:30 UTC
Created attachment 2655 [details]
error

When you try to add a barcode to a list on the staff client that doesn't exist your error reads "A record matching barcode 123456987 has already been added." -- it should instead say that this barcode doesn't exist.
Comment 1 Owen Leonard 2010-10-04 14:33:28 UTC
Created attachment 2662 [details] [review]
Proposed fix

The check to see if an item exists always evaluates as true.
Correcting this lets the script handle the error as it
was designed to.
Comment 2 Nicole C. Engard 2010-10-04 15:12:39 UTC
signed off on patch - much better!
Comment 3 MJ Ray (software.coop) 2010-11-19 16:33:23 UTC
This bug is mentioned in:
Fix for Bug 5265,	error message on lists is misleading http://lists.koha-community.org/pipermail/koha-patches/2010-October/012607.html
Fix for Bug 5265,	error message on lists is misleading http://lists.koha-community.org/pipermail/koha-patches/2010-October/012609.html
Comment 4 Chris Cormack 2010-11-21 20:16:57 UTC
This has been applied to master, please test and close