From 7fe73f0c5d8174cc093f5dd27ab2d8051cbd4a7b Mon Sep 17 00:00:00 2001 From: Jesse Weaver Date: Thu, 20 Mar 2014 11:20:40 -0600 Subject: [PATCH] [PASSED QA] Bug 11978 - Fix URLs displayed in OverDrive search OverDrive has recently changed its APIs to include "http://" in the URLs it returns. This patch removes the "http://" on the Koha end so they aren't doubled. Test plan: 1. Run an OverDrive search on the OPAC. 2. Check the links, they should start with "http://http://" 3. Apply this patch. 4. Rerun the search, the links should now be correct. Signed-off-by: Owen Leonard I can reproduce the problem and confirm that this patch fixes it. Signed-off-by: Katrin Fischer Patch removes hardcoded http:// from URLs in the Overdrive code. Trusting Jesse and Owen to have tested this with Overdrive, code review reveals no additional changes or possible problems. --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt | 6 +++--- koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt index 9aeff2d..1d3924f 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt @@ -79,7 +79,7 @@ function fetch_availability( prod, $tr ) { $availability_summary.find( '.available' ).append( ', ' + _("waiting holds:") + ' ' + data.numberOfHolds + '' ); } - $tr.find( '.info' ).append( '' ); + $tr.find( '.info' ).append( '' ); } ); } @@ -108,7 +108,7 @@ function search( offset ) { results.push( '' ); - results.push( '' ); + results.push( '' ); results.push( prod.title ); if ( prod.subtitle ) results.push( ', ', prod.subtitle ); results.push( '' ); @@ -127,7 +127,7 @@ function search( offset ) { results.push( '' ); if ( prod.images.thumbnail ) { - results.push( '' ); + results.push( '' ); results.push( '' ); results.push( '' ); } diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt index 2114c2a..f80e46a 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-overdrive-search.tt @@ -25,7 +25,7 @@ function fetch_availability( prod, $tr ) { $availability_summary.find( '.available' ).append( ', ' + _("waiting holds:") + ' ' + data.numberOfHolds + '' ); } - $tr.find( '.info' ).append( '' + _("Actions:") + ' ' + _("Check out") ) : ( ' class="hold">' + _("Place hold") ) ) + '' ); + $tr.find( '.info' ).append( '' + _("Actions:") + ' ' + _("Check out") ) : ( ' class="hold">' + _("Place hold") ) ) + '' ); } ); } @@ -54,7 +54,7 @@ function search( offset ) { results.push( '' ); - results.push( '' ); + results.push( '' ); results.push( prod.title ); if ( prod.subtitle ) results.push( ', ', prod.subtitle ); results.push( '' ); @@ -71,7 +71,7 @@ function search( offset ) { results.push( '' ); if ( prod.images.thumbnail ) { - results.push( '' ); + results.push( '' ); results.push( '' ); results.push( '' ); } -- 1.8.3.2