Bugzilla – Attachment 2741 Details for
Bug 5392
reserve/renewscript logging lots of warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed Patch
0001-Bug-5392-Initialize-vars-used-in-building-url-string.patch (text/plain), 1.43 KB, created by
Colin Campbell
on 2010-11-12 11:46:56 UTC
(
hide
)
Description:
Proposed Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2010-11-12 11:46:56 UTC
Size:
1.43 KB
patch
obsolete
>From 8e107a91f6c9900dd59ed64303e7f78d0010dbcc Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Fri, 12 Nov 2010 11:41:13 +0000 >Subject: [PATCH] Bug 5392 Initialize vars used in building url strings >Content-Type: text/plain; charset="utf-8" > >If no failures are to be added to the to the strings for redirect >the corresponding variables are undefined causing warnings >to be logged. Initialize them so that the error log is not >being filled with trivia. >--- > reserve/renewscript.pl | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/reserve/renewscript.pl b/reserve/renewscript.pl >index 4444e7c..ad746c9 100755 >--- a/reserve/renewscript.pl >+++ b/reserve/renewscript.pl >@@ -77,7 +77,7 @@ my $cardnumber = $input->param("cardnumber"); > my $borrowernumber = $input->param("borrowernumber"); > my $exemptfine = $input->param("exemptfine") || 0; > my $override_limit = $input->param("override_limit") || 0; >-my $failedrenews; >+my $failedrenews = q{}; > foreach my $itemno (@data) { > # check status before renewing issue > my ($renewokay,$error) = CanBookBeRenewed($borrowernumber,$itemno,$override_limit); >@@ -88,7 +88,7 @@ foreach my $itemno (@data) { > $failedrenews.="&failedrenew=$itemno"; > } > } >-my $failedreturn; >+my $failedreturn = q{}; > foreach my $barcode (@barcodes) { > # check status before renewing issue > my ( $returned, $messages, $issueinformation, $borrower ) = >-- >1.7.3.2 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5392
: 2741