Bug 5392 - reserve/renewscript logging lots of warnings
Summary: reserve/renewscript logging lots of warnings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-12 11:40 UTC by Colin Campbell
Modified: 2010-11-30 15:54 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.43 KB, patch)
2010-11-12 11:46 UTC, Colin Campbell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2010-11-12 11:40:32 UTC
In the course of debugging a site problem found reserve/renewscript.pl logging 
loads of 'Use of uninitialized value in concatenation' errors. 

In the redirects in the script two variables are used to convey failures but if no failures are encountered remain undef. Initialize the vars to an empty string and silence the warnings
Comment 1 Colin Campbell 2010-11-12 11:46:56 UTC
Created attachment 2741 [details] [review]
Proposed Patch
Comment 2 Chris Cormack 2010-11-12 22:39:23 UTC
Patch pushed, please test and close
Comment 3 Chris Nighswonger 2010-11-18 03:15:42 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 4 Chris Nighswonger 2010-11-30 15:54:55 UTC
A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1.