Bugzilla – Attachment 2786 Details for
Bug 5443
Inaccurate highlighting of fields in request for update of record email
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed fix
0001-Fix-for-Bug-5443-Inaccurate-highlighting-of-fields-i.patch (text/plain), 3.45 KB, created by
Owen Leonard
on 2010-11-24 20:53:37 UTC
(
hide
)
Description:
Proposed fix
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2010-11-24 20:53:37 UTC
Size:
3.45 KB
patch
obsolete
>From d705a907fcf64a4e249aafe250c4417f84caf139 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 24 Nov 2010 15:49:35 -0500 >Subject: [PATCH] Fix for Bug 5443, Inaccurate highlighting of fields in patron update email > >- email was incorrectly named emailaddress >- string processing was being done to address and B_address > which didn't seem to be serving a purpose >--- > .../opac-tmpl/prog/en/modules/opac-userupdate.tmpl | 2 +- > opac/opac-userupdate.pl | 14 ++------------ > 2 files changed, 3 insertions(+), 13 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl >index 64c81f2..ad29dd8 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tmpl >@@ -37,7 +37,7 @@ > <li><label for="mobile">Mobile Phone:</label> <input id="mobile" type="text" value="<!-- TMPL_VAR name="mobile" -->" name="mobile" /></li> > <li><label for="phonepro">Work phone:</label> <input id="phonepro" type="text" value="<!-- TMPL_VAR name="phonepro" -->" name="phonepro" /></li> > <li><label for="fax">Fax:</label> <input id="fax" type="text" value="<!-- TMPL_VAR name="fax" -->" name="fax" /></li> >-<li><label for="emailaddress">Email:</label> <input id="emailaddress" type="text" value="<!-- TMPL_VAR name="email" -->" name="emailaddress" /></li> >+<li><label for="emailaddress">Email:</label> <input id="emailaddress" type="text" value="<!-- TMPL_VAR name="email" -->" name="email" /></li> > <li><label for="emailpro">Work Email:</label> <input id="emailpro" type="text" value="<!-- TMPL_VAR name="emailpro" -->" name="emailpro" /></li> > </ol> > </fieldset> >diff --git a/opac/opac-userupdate.pl b/opac/opac-userupdate.pl >index b38a477..ec1300f 100755 >--- a/opac/opac-userupdate.pl >+++ b/opac/opac-userupdate.pl >@@ -53,7 +53,7 @@ my $lib = GetBranchDetail($borr->{'branchcode'}); > # handle the new information.... > # collect the form values and send an email. > my @fields = ( >- 'surname','firstname','othernames','streetnumber','address','address2','city','zipcode','country','phone','mobile','fax','phonepro', 'emailaddress','emailpro','B_streetnumber','B_address','B_address2','B_city','B_zipcode','B_country','B_phone','B_email','dateofbirth','sex' >+ 'surname','firstname','othernames','streetnumber','address','address2','city','zipcode','country','phone','mobile','fax','phonepro', 'email','emailpro','B_streetnumber','B_address','B_address2','B_city','B_zipcode','B_country','B_phone','B_email','dateofbirth','sex' > ); > my $update; > my $updateemailaddress = $lib->{'branchemail'}; >@@ -84,7 +84,7 @@ if ( $query->param('modify') ) { > > # get all the fields: > my $message = <<"EOF"; >-Borrower $borr->{'cardnumber'} >+Patron $borr->{'cardnumber'} > > has requested to change her/his personal details. > Please check these new details and make the changes: >@@ -104,16 +104,6 @@ EOF > $borrowerfield = $borr->{$field}; > } > >- # reconstruct the address >- if($field eq "address") { >- $borrowerfield = "$streetnumber $address, $address2"; >- } >- >- # reconstruct the alternate address >- if($field eq "B_address") { >- $borrowerfield = "$B_streetnumber $B_address, $B_address2"; >- } >- > if($field eq "dateofbirth") { > $borrowerfield = format_date( $borr->{'dateofbirth'} ) || ''; > } >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5443
: 2786