The "User request for update of record" email includes a feature which puts the field label (in the email) in all caps if that field has an updated value: address2 : --> CITY : Albany --> Athens, OH zipcode : 45710 --> 45710 country : U.S.A. --> U.S.A. The "city" field has been changed by the user, so the label reads "CITY." However, three fields always report a change whether or not a change has been made: email, address, and B_address.
Created attachment 2786 [details] [review] Proposed fix - email was incorrectly named emailaddress - string processing was being done to address and B_address which didn't seem to be serving a purpose and was causing the false positive.
Patch pushed, please test
This bug is mentioned in: Fix for Bug 5443, Inaccurate highlighting of fields in patron update email http://lists.koha-community.org/pipermail/koha-patches/2010-November/013098.html