Bug 5443 - Inaccurate highlighting of fields in request for update of record email
Summary: Inaccurate highlighting of fields in request for update of record email
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: /cgi-bin/koha/opac-userupdate.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-24 20:49 UTC by Owen Leonard
Modified: 2012-10-25 22:52 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.45 KB, patch)
2010-11-24 20:53 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-11-24 20:49:04 UTC
The "User request for update of record" email includes a feature which puts the field label (in the email) in all caps if that field has an updated value:

address2 :   -->
CITY : Albany  -->  Athens, OH
zipcode : 45710  -->  45710
country : U.S.A.  -->  U.S.A.

The "city" field has been changed by the user, so the label reads "CITY."

However, three fields always report a change whether or not a change has been made: email, address, and B_address.
Comment 1 Owen Leonard 2010-11-24 20:53:37 UTC
Created attachment 2786 [details] [review]
Proposed fix

- email was incorrectly named emailaddress
- string processing was being done to address and B_address which didn't seem to be serving a purpose and was causing the false positive.
Comment 2 Chris Cormack 2010-12-12 21:10:55 UTC
Patch pushed, please test
Comment 3 MJ Ray (software.coop) 2010-12-13 12:16:28 UTC
This bug is mentioned in:
Fix for Bug 5443,	Inaccurate highlighting of fields in patron update email http://lists.koha-community.org/pipermail/koha-patches/2010-November/013098.html