Bugzilla – Attachment 29778 Details for
Bug 11349
PROG/CCSR deprecation: Remove .tmpl -> .tt translation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11349: Make the QA script happy
Bug-11349-Make-the-QA-script-happy.patch (text/plain), 17.52 KB, created by
Chris Cormack
on 2014-07-17 01:08:01 UTC
(
hide
)
Description:
Bug 11349: Make the QA script happy
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2014-07-17 01:08:01 UTC
Size:
17.52 KB
patch
obsolete
>From f1555717d2dbe61a5a736b2444d44f556e1872d7 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Wed, 9 Jul 2014 10:36:39 -0300 >Subject: [PATCH] Bug 11349: Make the QA script happy > >This patch just adjusts several POD stuff, and in a few cases >reorganizes a hash definition in order to use spaces instead of tabs >for the QA script to be happy. > >Nothing important, really. This patch series just changes '.tmpl' for >'.tt'. > >Regards >To+ > >PS beware that running the koha-qa.pl script can take lots of time on this one >:-D > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > authorities/detail-biblio-search.pl | 18 +++++++++------- > .../value_builder/marc21_leader_computerfile.pl | 6 ++++-- > cataloguing/value_builder/normarc_field_008.pl | 6 ++++-- > cataloguing/value_builder/unimarc_field_123i.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_123j.pl | 6 ++++-- > cataloguing/value_builder/unimarc_field_124.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_124a.pl | 25 +++++++++++++--------- > cataloguing/value_builder/unimarc_field_124g.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_126.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_127.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_128a.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_128c.pl | 6 ++++-- > cataloguing/value_builder/unimarc_field_135a.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_140.pl | 7 ++++-- > cataloguing/value_builder/unimarc_field_210c.pl | 16 ++++++++------ > cataloguing/value_builder/unimarc_leader.pl | 6 ++++-- > members/mancredit.pl | 2 +- > members/statistics.pl | 9 ++++++++ > reports/acquisitions_stats.pl | 7 ++---- > reports/borrowers_out.pl | 4 ++-- > reports/issues_stats.pl | 5 ++--- > serials/acqui-search-result.pl | 1 + > virtualshelves/addbybiblionumber.pl | 2 +- > 23 files changed, 113 insertions(+), 62 deletions(-) > >diff --git a/authorities/detail-biblio-search.pl b/authorities/detail-biblio-search.pl >index 8a4b1c1..eed059c 100755 >--- a/authorities/detail-biblio-search.pl >+++ b/authorities/detail-biblio-search.pl >@@ -62,14 +62,16 @@ my $tagslib = &GetTagsLabels(1,$authtypecode); > > my $record =GetAuthority($authid); > # open template >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "authorities/detail-biblio-search.tt", >- query => $query, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {catalogue => 1}, >- debug => 1, >- }); >+my ($template, $loggedinuser, $cookie) = get_template_and_user( >+ { >+ template_name => "authorities/detail-biblio-search.tt", >+ query => $query, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { catalogue => 1 }, >+ debug => 1, >+ } >+); > > # fill arrays > my @loop_data =(); >diff --git a/cataloguing/value_builder/marc21_leader_computerfile.pl b/cataloguing/value_builder/marc21_leader_computerfile.pl >index 813556a..0c6a576 100755 >--- a/cataloguing/value_builder/marc21_leader_computerfile.pl >+++ b/cataloguing/value_builder/marc21_leader_computerfile.pl >@@ -27,9 +27,11 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut > >diff --git a/cataloguing/value_builder/normarc_field_008.pl b/cataloguing/value_builder/normarc_field_008.pl >index 7f45c19..d5acce0 100755 >--- a/cataloguing/value_builder/normarc_field_008.pl >+++ b/cataloguing/value_builder/normarc_field_008.pl >@@ -25,9 +25,11 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut > >diff --git a/cataloguing/value_builder/unimarc_field_123i.pl b/cataloguing/value_builder/unimarc_field_123i.pl >index d0d81b3..8b39e73 100755 >--- a/cataloguing/value_builder/unimarc_field_123i.pl >+++ b/cataloguing/value_builder/unimarc_field_123i.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_123j.pl b/cataloguing/value_builder/unimarc_field_123j.pl >index 1c8a2c1..9b0903e 100755 >--- a/cataloguing/value_builder/unimarc_field_123j.pl >+++ b/cataloguing/value_builder/unimarc_field_123j.pl >@@ -27,9 +27,11 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut > >diff --git a/cataloguing/value_builder/unimarc_field_124.pl b/cataloguing/value_builder/unimarc_field_124.pl >index be4dd23..4f2bc8c 100755 >--- a/cataloguing/value_builder/unimarc_field_124.pl >+++ b/cataloguing/value_builder/unimarc_field_124.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_124a.pl b/cataloguing/value_builder/unimarc_field_124a.pl >index 2ac8a53..08563a9 100755 >--- a/cataloguing/value_builder/unimarc_field_124a.pl >+++ b/cataloguing/value_builder/unimarc_field_124a.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >@@ -68,14 +71,16 @@ my ($input) = @_; > > my $dbh = C4::Context->dbh; > >-my ($template, $loggedinuser, $cookie) >- = get_template_and_user({template_name => "cataloguing/value_builder/unimarc_field_124a.tt", >- query => $input, >- type => "intranet", >- authnotrequired => 0, >- flagsrequired => {editcatalogue => '*'}, >- debug => 1, >- }); >+ my ($template, $loggedinuser, $cookie) = get_template_and_user( >+ { >+ template_name => "cataloguing/value_builder/unimarc_field_124a.tt", >+ query => $input, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { editcatalogue => '*' }, >+ debug => 1, >+ } >+ ); > my $f1 = substr($result,0,1); > $template->param(index => $index, > "f1$f1" => 1); >diff --git a/cataloguing/value_builder/unimarc_field_124g.pl b/cataloguing/value_builder/unimarc_field_124g.pl >index feade5b..5319217 100755 >--- a/cataloguing/value_builder/unimarc_field_124g.pl >+++ b/cataloguing/value_builder/unimarc_field_124g.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_126.pl b/cataloguing/value_builder/unimarc_field_126.pl >index be4dd23..4f2bc8c 100755 >--- a/cataloguing/value_builder/unimarc_field_126.pl >+++ b/cataloguing/value_builder/unimarc_field_126.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_127.pl b/cataloguing/value_builder/unimarc_field_127.pl >index 4dfeb74..16195fe 100755 >--- a/cataloguing/value_builder/unimarc_field_127.pl >+++ b/cataloguing/value_builder/unimarc_field_127.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_128a.pl b/cataloguing/value_builder/unimarc_field_128a.pl >index 4628781..ef1b006 100755 >--- a/cataloguing/value_builder/unimarc_field_128a.pl >+++ b/cataloguing/value_builder/unimarc_field_128a.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_128c.pl b/cataloguing/value_builder/unimarc_field_128c.pl >index a4b129d..359d8e3 100755 >--- a/cataloguing/value_builder/unimarc_field_128c.pl >+++ b/cataloguing/value_builder/unimarc_field_128c.pl >@@ -27,9 +27,11 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut > >diff --git a/cataloguing/value_builder/unimarc_field_135a.pl b/cataloguing/value_builder/unimarc_field_135a.pl >index ae17fd4..fab677d 100755 >--- a/cataloguing/value_builder/unimarc_field_135a.pl >+++ b/cataloguing/value_builder/unimarc_field_135a.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_140.pl b/cataloguing/value_builder/unimarc_field_140.pl >index 1eecfab..524f0dc 100755 >--- a/cataloguing/value_builder/unimarc_field_140.pl >+++ b/cataloguing/value_builder/unimarc_field_140.pl >@@ -27,11 +27,14 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; >diff --git a/cataloguing/value_builder/unimarc_field_210c.pl b/cataloguing/value_builder/unimarc_field_210c.pl >index 474c41d..e6dace6 100755 >--- a/cataloguing/value_builder/unimarc_field_210c.pl >+++ b/cataloguing/value_builder/unimarc_field_210c.pl >@@ -32,19 +32,22 @@ use C4::Koha; > > ###TODO To rewrite in order to use SearchAuthorities > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut >+ > sub plugin_parameters { > my ($dbh,$record,$tagslib,$i,$tabloop) = @_; > return ""; > } > >-=head1 >+=head2 plugin_javascript > >-plugin_javascript : the javascript function called when the user enters the subfield. >+The javascript function called when the user enters the subfield. > contain 3 javascript functions : > * one called when the field is entered (OnFocus). Named FocusXXX > * one called when the field is leaved (onBlur). Named BlurXXX >@@ -56,6 +59,7 @@ returns : > the 3 scripts are inserted after the <input> in the html code > > =cut >+ > sub plugin_javascript { > my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_; > my $function_name= $field_number; >@@ -86,9 +90,9 @@ function Clic$function_name(subfield_managed) { > return ($function_name,$res); > } > >-=head1 >+=head2 plugin > >-plugin : the true value_builded. The screen that is open in the popup window. >+The true value_builded. The screen that is open in the popup window. > > =cut > >diff --git a/cataloguing/value_builder/unimarc_leader.pl b/cataloguing/value_builder/unimarc_leader.pl >index baf42f3..497d9a7 100755 >--- a/cataloguing/value_builder/unimarc_leader.pl >+++ b/cataloguing/value_builder/unimarc_leader.pl >@@ -27,9 +27,11 @@ use C4::Context; > use C4::Search; > use C4::Output; > >-=head1 >+=head1 FUNCTIONS > >-plugin_parameters : other parameters added when the plugin is called by the dopop function >+=head2 plugin_parameters >+ >+Other parameters added when the plugin is called by the dopop function > > =cut > >diff --git a/members/mancredit.pl b/members/mancredit.pl >index 5179c34..e52219f 100755 >--- a/members/mancredit.pl >+++ b/members/mancredit.pl >@@ -60,7 +60,7 @@ if ($add){ > print $input->redirect("/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber"); > } > } else { >- my ($template, $loggedinuser, $cookie) = get_template_and_user( >+ my ($template, $loggedinuser, $cookie) = get_template_and_user( > { > template_name => "members/mancredit.tt", > query => $input, >diff --git a/members/statistics.pl b/members/statistics.pl >index c462871..5222cf0 100755 >--- a/members/statistics.pl >+++ b/members/statistics.pl >@@ -17,7 +17,9 @@ > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > =head1 members/statistics.pl >+ > Generate statistic issues for a member >+ > =cut > > use Modern::Perl; >@@ -112,9 +114,12 @@ output_html_with_http_headers $input, $cookie, $template->output; > =head1 FUNCTIONS > > =head2 add_actual_state >+ > Add a 'count_actual_state' key in all hashes > count_actual_state = count_precedent_state - count_total_issues_returned_today + count_total_issues_today >+ > =cut >+ > sub add_actual_state { > my ( $array ) = @_; > for my $hash ( @$array ) { >@@ -123,6 +128,7 @@ sub add_actual_state { > } > > =head2 build_array >+ > Build a new array containing values of hashes. > It used by template whitch display silly values. > ex: >@@ -151,6 +157,7 @@ sub add_actual_state { > ]; > > =cut >+ > sub build_array { > my ( $array ) = @_; > my ( @r, $total ); >@@ -173,6 +180,7 @@ sub build_array { > } > > =head2 merge >+ > Merge hashes with the same statistic column names into one > param: array, a arrayref of arrayrefs > ex: >@@ -202,6 +210,7 @@ sub build_array { > ]; > > =cut >+ > sub merge { > my @array = @_; > my @r; >diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl >index 56032c2..b19bf8e 100755 >--- a/reports/acquisitions_stats.pl >+++ b/reports/acquisitions_stats.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -18,8 +17,6 @@ > # with Koha; if not, write to the Free Software Foundation, Inc., > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > >-# test comment >- > use Modern::Perl; > > use C4::Auth; >@@ -35,11 +32,11 @@ use C4::Biblio; > > =head1 NAME > >-plugin that shows a stats on borrowers >+reports/acquisitions_stats.pl > > =head1 DESCRIPTION > >-=over 2 >+Plugin that shows a stats on borrowers > > =cut > >diff --git a/reports/borrowers_out.pl b/reports/borrowers_out.pl >index 14d59ab..74f80bf 100755 >--- a/reports/borrowers_out.pl >+++ b/reports/borrowers_out.pl >@@ -32,11 +32,11 @@ use C4::Dates qw/format_date_in_iso/; > > =head1 NAME > >-plugin that shows a stats on borrowers >+reports/borrowers_out.pl > > =head1 DESCRIPTION > >-=over 2 >+Plugin that shows a stats on borrowers > > =cut > >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 0df9942..b0fc72c 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -1,6 +1,5 @@ > #!/usr/bin/perl > >- > # Copyright 2000-2002 Katipo Communications > # > # This file is part of Koha. >@@ -37,11 +36,11 @@ use C4::Members; > > =head1 NAME > >-plugin that shows circulation stats >+reports/issues_stats.pl > > =head1 DESCRIPTION > >-=over 2 >+Plugin that shows circulation stats > > =cut > >diff --git a/serials/acqui-search-result.pl b/serials/acqui-search-result.pl >index 8a2d7d9..c956439 100755 >--- a/serials/acqui-search-result.pl >+++ b/serials/acqui-search-result.pl >@@ -26,6 +26,7 @@ > acqui-search-result.pl > > =head1 DESCRIPTION >+ > TODO > > =head1 PARAMETERS >diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl >index 52685c1..289a4aa 100755 >--- a/virtualshelves/addbybiblionumber.pl >+++ b/virtualshelves/addbybiblionumber.pl >@@ -23,7 +23,7 @@ > > =head1 NAME > >- addbybiblionumber.pl >+addbybiblionumber.pl > > =head1 DESCRIPTION > >-- >2.0.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11349
:
29582
|
29583
|
29584
|
29773
|
29774
|
29775
|
29776
|
29777
|
29778
|
29782
|
29783
|
29784
|
29785