bootstrap should not have any .tmpl files, so no need to keep the code that does that translation anymore. We should get rid of it.
Created attachment 29582 [details] [review] Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code.
Created attachment 29583 [details] [review] Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+
Created attachment 29584 [details] [review] Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D
A messy little conflict on admin/z3950servers.pl otherwise seems fine. Happy to try sign off again when the conflict is tidied.
Created attachment 29773 [details] [review] Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code.
Created attachment 29774 [details] [review] Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+
Created attachment 29775 [details] [review] Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D
Rebased against master.
Created attachment 29776 [details] [review] Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 29777 [details] [review] Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 29778 [details] [review] Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 29782 [details] [review] Bug 11349: Change .tmpl -> .tt in scripts using templates Since we switched to Template Toolkit we don't need to stick with the sufix we used for HTML::Template::Pro. This patch changes the occurences of '.tmpl' in favour of '.tt'. To test: - Apply the patch - Install koha, and verify that every page can be accesed Regards To+ P.S. a followup will remove the glue code. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 29783 [details] [review] Bug 11349: Remove unnecesary name translation Since all scripts use the '.tt' sufix for template names there's no need for and regexp that changes from '.tmpl' to '.tt'. Regards To+ Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 29784 [details] [review] Bug 11349: Make the QA script happy This patch just adjusts several POD stuff, and in a few cases reorganizes a hash definition in order to use spaces instead of tabs for the QA script to be happy. Nothing important, really. This patch series just changes '.tmpl' for '.tt'. Regards To+ PS beware that running the koha-qa.pl script can take lots of time on this one :-D Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 29785 [details] [review] Bug 11349: (qa follow-up) Fix pod FAIL cataloguing/value_builder/unimarc_field_125.pl FAIL pod *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_125.pl *** ERROR: Spurious text after =cut in file cataloguing/value_builder/unimarc_field_125.pl FAIL cataloguing/value_builder/unimarc_field_126b.pl FAIL pod *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_126b.pl *** ERROR: Spurious text after =cut in file cataloguing/value_builder/unimarc_field_126b.pl FAIL cataloguing/value_builder/unimarc_field_225a.pl FAIL pod *** ERROR: =over on line 40 without closing =back (at head1) in file cataloguing/value_builder/unimarc_field_225a.pl *** ERROR: empty =head1 in file cataloguing/value_builder/unimarc_field_225a.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I added a new test in qa tests. commit dacebd6ee4c5df57f0b2ee266e8f425feaee176f Author: Jonathan Druart <jonathan.druart@biblibre.com> Date: Thu Jul 17 11:12:38 2014 +0200 template name should not contain .tmpl anymore
Patches pushed to master.