Bug 11349 - PROG/CCSR deprecation: Remove .tmpl -> .tt translation
Summary: PROG/CCSR deprecation: Remove .tmpl -> .tt translation
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 11346
  Show dependency treegraph
 
Reported: 2013-12-06 02:25 UTC by Liz Rea
Modified: 2015-06-04 23:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11349: Change .tmpl -> .tt in scripts using templates (234.39 KB, patch)
2014-07-09 14:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11349: Remove unnecesary name translation (1.85 KB, patch)
2014-07-09 14:06 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11349: Make the QA script happy (17.47 KB, patch)
2014-07-09 14:07 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11349: Change .tmpl -> .tt in scripts using templates (239.17 KB, patch)
2014-07-17 00:36 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11349: Remove unnecesary name translation (2.73 KB, patch)
2014-07-17 00:37 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11349: Make the QA script happy (17.47 KB, patch)
2014-07-17 00:37 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11349: Change .tmpl -> .tt in scripts using templates (239.23 KB, patch)
2014-07-17 01:07 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11349: Remove unnecesary name translation (2.79 KB, patch)
2014-07-17 01:07 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11349: Make the QA script happy (17.52 KB, patch)
2014-07-17 01:08 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11349: Change .tmpl -> .tt in scripts using templates (239.29 KB, patch)
2014-07-17 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11349: Remove unnecesary name translation (2.85 KB, patch)
2014-07-17 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11349: Make the QA script happy (17.59 KB, patch)
2014-07-17 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11349: (qa follow-up) Fix pod (2.96 KB, patch)
2014-07-17 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2013-12-06 02:25:41 UTC
bootstrap should not have any .tmpl files, so no need to keep the code that does that translation anymore. We should get rid of it.
Comment 1 Tomás Cohen Arazi 2014-07-09 14:06:51 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2014-07-09 14:06:58 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2014-07-09 14:07:03 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2014-07-16 23:55:04 UTC
A messy little conflict on admin/z3950servers.pl  otherwise seems fine. Happy to try sign off again when the conflict is tidied.
Comment 5 Tomás Cohen Arazi 2014-07-17 00:36:57 UTC Comment hidden (obsolete)
Comment 6 Tomás Cohen Arazi 2014-07-17 00:37:13 UTC Comment hidden (obsolete)
Comment 7 Tomás Cohen Arazi 2014-07-17 00:37:59 UTC Comment hidden (obsolete)
Comment 8 Tomás Cohen Arazi 2014-07-17 00:38:27 UTC
Rebased against master.
Comment 9 Chris Cormack 2014-07-17 01:07:29 UTC Comment hidden (obsolete)
Comment 10 Chris Cormack 2014-07-17 01:07:45 UTC Comment hidden (obsolete)
Comment 11 Chris Cormack 2014-07-17 01:08:01 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2014-07-17 08:52:13 UTC
Created attachment 29782 [details] [review]
Bug 11349: Change .tmpl -> .tt in scripts using templates

Since we switched to Template Toolkit we don't need to stick with the
sufix we used for HTML::Template::Pro.

This patch changes the occurences of '.tmpl' in favour of '.tt'.

To test:
- Apply the patch
- Install koha, and verify that every page can be accesed

Regards
To+

P.S. a followup will remove the glue code.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 13 Jonathan Druart 2014-07-17 08:52:17 UTC
Created attachment 29783 [details] [review]
Bug 11349: Remove unnecesary name translation

Since all scripts use the '.tt' sufix for template names
there's no need for and regexp that changes from '.tmpl'
to '.tt'.

Regards
To+

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 14 Jonathan Druart 2014-07-17 08:52:23 UTC
Created attachment 29784 [details] [review]
Bug 11349: Make the QA script happy

This patch just adjusts several POD stuff, and in a few cases
reorganizes a hash definition in order to use spaces instead of tabs
for the QA script to be happy.

Nothing important, really. This patch series just changes '.tmpl' for
'.tt'.

Regards
To+

PS beware that running the koha-qa.pl script can take lots of time on this one
:-D

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 15 Jonathan Druart 2014-07-17 08:52:28 UTC
Created attachment 29785 [details] [review]
Bug 11349: (qa follow-up) Fix pod

FAIL   cataloguing/value_builder/unimarc_field_125.pl
   FAIL   pod
    *** ERROR: empty =head1  in file cataloguing/value_builder/unimarc_field_125.pl
    *** ERROR: Spurious text after =cut  in file cataloguing/value_builder/unimarc_field_125.pl

 FAIL   cataloguing/value_builder/unimarc_field_126b.pl
   FAIL   pod
    *** ERROR: empty =head1  in file cataloguing/value_builder/unimarc_field_126b.pl
    *** ERROR: Spurious text after =cut  in file cataloguing/value_builder/unimarc_field_126b.pl

 FAIL   cataloguing/value_builder/unimarc_field_225a.pl
   FAIL   pod
    *** ERROR: =over on line 40 without closing =back (at head1)  in file cataloguing/value_builder/unimarc_field_225a.pl
    *** ERROR: empty =head1  in file cataloguing/value_builder/unimarc_field_225a.pl

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 16 Jonathan Druart 2014-07-17 09:41:13 UTC
I added a new test in qa tests.

commit dacebd6ee4c5df57f0b2ee266e8f425feaee176f
Author: Jonathan Druart <jonathan.druart@biblibre.com>
Date:   Thu Jul 17 11:12:38 2014 +0200

    template name should not contain .tmpl anymore
Comment 17 Tomás Cohen Arazi 2014-07-17 14:25:38 UTC
Patches pushed to master.