Bugzilla – Attachment 30544 Details for
Bug 12693
colspan calculation done by members/statistics.pl should be moved to template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[Signed-off] Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template
Signed-off-Bug-12693---colspan-calculation-done-by.patch (text/plain), 2.24 KB, created by
Marc Véron
on 2014-08-05 09:11:56 UTC
(
hide
)
Description:
[Signed-off] Bug 12693 - colspan calculation done by members/statistics.pl should be moved to template
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2014-08-05 09:11:56 UTC
Size:
2.24 KB
patch
obsolete
>From 63d3b806883e822cf30d1fa8189e41b77cfdea41 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 1 Aug 2014 14:58:35 -0400 >Subject: [PATCH] [Signed-off] Bug 12693 - colspan calculation done by > members/statistics.pl should be moved to template >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >It is not necessary for the patron statistics script to pass a colspan >value to the template. The number can be output using Template::Toolkit >syntax. > >To test, view the statistics page for a patron. Confirm that the "Total" >cell in the footer spans the correct number of columns. Test with >various numbers of fields in the StatisticsFields system preference. > >Followed test plan. Patch behaves as expected. >Signed-off-by: Marc Véron <veron@veron.ch> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt | 2 +- > members/statistics.pl | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt >index b034613..876559a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt >@@ -78,7 +78,7 @@ > </tbody> > <tfoot> > <tr> >- <td colspan="[% length_keys %]">TOTAL</td> >+ <td colspan="[% column_names.size %]">TOTAL</td> > <td>[% count_total_precedent_state %]</td> > <td>[% count_total_issues %]</td> > <td>[% count_total_issues_returned %]</td> >diff --git a/members/statistics.pl b/members/statistics.pl >index 15a1c69..af31815 100755 >--- a/members/statistics.pl >+++ b/members/statistics.pl >@@ -105,7 +105,6 @@ $template->param( > datas => $datas, > address => $address, > column_names => \@statistic_column_names, >- length_keys => scalar( @statistic_column_names), > count_total_issues => $count_total_issues, > count_total_issues_returned => $count_total_issues_returned, > count_total_precedent_state => $count_total_precedent_state, >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12693
:
30471
|
30544
|
30572