Bugzilla – Attachment 30824 Details for
Bug 12697
Surplus closing </div> in OPAC advanced search (bootstrap)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)
PASSED-QA-Bug-12697---Surplus-closing-div-in-OPAC-.patch (text/plain), 2.75 KB, created by
Katrin Fischer
on 2014-08-15 10:03:55 UTC
(
hide
)
Description:
[PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-15 10:03:55 UTC
Size:
2.75 KB
patch
obsolete
>From 826364004c94d3aad24e149f040b9756aea193a4 Mon Sep 17 00:00:00 2001 >From: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Date: Sat, 2 Aug 2014 10:13:16 +0200 >Subject: [PATCH] [PASSED QA] Bug 12697 - Surplus closing </div> in OPAC > advanced search (bootstrap) > >In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, >there is a surplus closing </div> in line 336 (= line 332, in case >Bug 12521 is applied first): > > 336: </div> <!-- / .span4 --> > >which causes some minor layout problems for this page - i.e.: page >footer ("Powered by Koha" + custom footer set up in system prefrences - >if any) is "glued" to the bottom (to the language selection bar); >unless Bug 12521 is applied first, this affects the placement of the >2nd search bar as well. > >To reproduce: > >1/ go to the OPAC advanced search page >2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the >result >3/ no need for step 2/ (zooming out) when using a display with >(relatively) high vertical resolution; also, this particullar problem >gets more apparent/more noticeable with MARC21/USMASRC "subtype" >options being hidden in the OPAC advanced search (Bug 9043). > >To test: > >1/ ensure that Bug 12521 is applied first/already applied >2/ apply patch >3/ confirm that this issue is no longer reroductible > >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >On top of 12521, don't know exactly what to reproduce, but >surplus '</div>' is real (33 open, 34 close). >Everything looks correct, no koha-qa errors. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >index d9b2d4b..15e3790 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt >@@ -325,7 +325,8 @@ > </fieldset> > </div> <!-- / .span3 --> > </div> <!-- / #subtypes --> >- [% END # / IF usmarc %] >+ <!-- SUBTYPE LIMITS --> >+ [% END # / IF usmarc %] > > [% IF ( UNIMARC ) %] > <div id="subtypes_unimarc"> >@@ -333,7 +334,7 @@ > [% INCLUDE 'subtypes_unimarc.inc' %] > </div> > [% END %] >- </div> <!-- / .span4 --> >+ > </div> <!-- / .row-fluid --> > [% END # / IF expanded_options %] > </div> <!-- / .row-fluid --> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12697
:
30486
|
30597
| 30824