Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)
Summary: Surplus closing </div> in OPAC advanced search (bootstrap)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jacek Ablewicz
QA Contact: Testopia
URL:
Keywords:
Depends on: 12521
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-02 08:12 UTC by Jacek Ablewicz
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) (2.47 KB, patch)
2014-08-02 08:22 UTC, Jacek Ablewicz
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) (2.69 KB, patch)
2014-08-07 20:50 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap) (2.75 KB, patch)
2014-08-15 10:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Ablewicz 2014-08-02 08:12:47 UTC
In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template, there is a surplus closing </div> in line 336 (= line 332, in case Bug 12521 is applied first):

   336: </div> <!-- / .span4 -->

which causes some minor layout problems for this page - i.e.: page footer ("Powered by Koha" + custom footer set up in system prefrences - if any) is "glued" to the bottom (to the language selection bar); unless Bug 12521 is applied first, this affects the placement of the 2nd search bar as well.

To reproduce:

1/ go to the OPAC advanced search page
2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the result
3/ no need for step 2/ (zooming out) when using a display with (relatively) high vertical resolution; also, this particullar problem gets more apparent/more noticeable with MARC21/USMASRC "subtype" options being hidden in the OPAC advanced search (Bug 9043).
Comment 1 Jacek Ablewicz 2014-08-02 08:22:31 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2014-08-07 20:50:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-08-15 10:03:55 UTC
Created attachment 30824 [details] [review]
[PASSED QA] Bug 12697 - Surplus closing </div> in OPAC advanced search (bootstrap)

In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt template,
there is a surplus closing </div> in line 336 (= line 332, in case
Bug 12521 is applied first):

   336: </div> <!-- / .span4 -->

which causes some minor layout problems for this page - i.e.: page
footer ("Powered by Koha" + custom footer set up in system prefrences -
if any) is "glued" to the bottom (to the language selection bar);
unless Bug 12521 is applied first, this affects the placement of the
2nd search bar as well.

To reproduce:

1/ go to the OPAC advanced search page
2/ zoom out (e.g., use Ctrl-<minus> several times) and obeserve the
result
3/ no need for step 2/ (zooming out) when using a display with
(relatively) high vertical resolution; also, this particullar problem
gets more apparent/more noticeable with MARC21/USMASRC "subtype"
options being hidden in the OPAC advanced search (Bug 9043).

To test:

1/ ensure that Bug 12521 is applied first/already applied
2/ apply patch
3/ confirm that this issue is no longer reroductible

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
On top of 12521, don't know exactly what to reproduce, but
surplus '</div>' is real (33 open, 34 close).
Everything looks correct, no koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2014-09-18 00:59:18 UTC
Patch pushed to master.

Thanks Jacek!