Bugzilla – Attachment 30854 Details for
Bug 12432
Saved reports tabs not working
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12432 - Saved reports tabs not working
PASSED-QA-Bug-12432---Saved-reports-tabs-not-worki.patch (text/plain), 2.13 KB, created by
Katrin Fischer
on 2014-08-15 17:16:53 UTC
(
hide
)
Description:
[PASSED QA] Bug 12432 - Saved reports tabs not working
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-08-15 17:16:53 UTC
Size:
2.13 KB
patch
obsolete
>From b8b1cf250fd39fc383fd2fd66af0a20b29261a36 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 28 Jul 2014 10:18:59 -0500 >Subject: [PATCH] [PASSED QA] Bug 12432 - Saved reports tabs not working > >In release 3.14.05.000 the tabs on the Saved Reports page worked >correctly but after upgrading to 3.16.00.000 the tabs stop working. >Visually the tabs change but the table of reports is not filtered. There >are no errors reported in the browser console. > >Test Plan: >1) Attempt to filter saved reports by group tabs >2) Note no matter the tab you select, all reports appear >3) Apply this patch >4) Repeat step 1 >5) Note the reports are now filtered correctly > >Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Passes all tests and QA script, works as described with the >second patch applied as well. >--- > .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 39f25c6..46ae365 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -76,7 +76,7 @@ $(document).ready(function(){ > })); > > var rtabs = $("#tabs").tabs(); >- rtabs.bind("tabsshow", function(e, ui) { >+ rtabs.on("tabsactivate", function(e, ui) { > $("#subgroup_filter option").each(function() { > if($(this).val().length > 0) { > $(this).remove(); >@@ -87,8 +87,9 @@ $(document).ready(function(){ > rtable.fnSetColumnVis(4, true); > rtable.fnSetColumnVis(5, true); > >- var g_id = $(ui.tab).attr('id') >- var g_name = $(ui.tab).text(); >+ var g_id = $(ui.newTab).children().attr('id'); >+ var g_name = $(ui.newTab).text(); >+ > if (g_id && g_id.length > 0) { > rtable.fnFilter('^' + g_name + '$', 4, true, true, true, false); > rtable.fnSetColumnVis(4, false); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12432
:
30214
|
30242
|
30831
| 30854 |
30855