In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. IE version 11.0.9600.17107 Chrome version 35.0.1916.153 m
Confirmed! The table of reports stays the same no matter what tab is clicked. Tested with Firefox 30.0 on Ubuntu 14.04.
3.14.8 doesn't work
Created attachment 30214 [details] [review] Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly
Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org>
Created attachment 30242 [details] [review] Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
I think there is still a bug there - when you switch back from say 'Acquisitions' to 'All' - it's empty. I have 2 reports, one has no group and the other is 'Acquisitions.
Created attachment 30831 [details] [review] Bug 12432 [QA Followup] - Make "All" tab work when switching back to it
Created attachment 30854 [details] [review] [PASSED QA] Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script, works as described with the second patch applied as well.
Created attachment 30855 [details] [review] [PASSED QA] Bug 12432 [QA Followup] - Make "All" tab work when switching back to it Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patches pushed to master. Thanks Kyle!
Pushed to 3.16.x for inclusion in 3.16.4.
Pushed to 3.14.x, will be in 3.14.12.