Bug 12432 - Saved reports tabs not working
Summary: Saved reports tabs not working
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-17 09:40 UTC by Pete Edwards
Modified: 2016-06-21 21:37 UTC (History)
10 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12432 - Saved reports tabs not working (1.91 KB, patch)
2014-07-28 15:27 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 12432 - Saved reports tabs not working (1.97 KB, patch)
2014-07-29 03:05 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 12432 [QA Followup] - Make "All" tab work when switching back to it (1.06 KB, patch)
2014-08-15 12:56 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 12432 - Saved reports tabs not working (2.13 KB, patch)
2014-08-15 17:16 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 12432 [QA Followup] - Make "All" tab work when switching back to it (1.13 KB, patch)
2014-08-15 17:17 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pete Edwards 2014-06-17 09:40:07 UTC
In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console.

IE version 11.0.9600.17107
Chrome version 35.0.1916.153 m
Comment 1 Magnus Enger 2014-06-17 09:51:01 UTC
Confirmed! The table of reports stays the same no matter what tab is clicked. Tested with Firefox 30.0 on Ubuntu 14.04.
Comment 2 Claudio Costales 2014-07-04 00:12:04 UTC
3.14.8 doesn't work
Comment 3 Kyle M Hall 2014-07-28 15:27:01 UTC Comment hidden (obsolete)
Comment 4 Biblibre Sandboxes 2014-07-29 03:05:36 UTC
Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org>
Comment 5 Biblibre Sandboxes 2014-07-29 03:05:55 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-07-29 21:33:40 UTC
I think there is still a bug there - when you switch back from say 'Acquisitions' to 'All' - it's empty.

I have 2 reports, one has no group and the other is 'Acquisitions.
Comment 7 Kyle M Hall 2014-08-15 12:56:59 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2014-08-15 17:16:53 UTC
Created attachment 30854 [details] [review]
[PASSED QA] Bug 12432 - Saved reports tabs not working

In release 3.14.05.000 the tabs on the Saved Reports page worked
correctly but after upgrading to 3.16.00.000 the tabs stop working.
Visually the tabs change but the table of reports is not filtered. There
are no errors reported in the browser console.

Test Plan:
1) Attempt to filter saved reports by group tabs
2) Note no matter the tab you select, all reports appear
3) Apply this patch
4) Repeat step 1
5) Note the reports are now filtered correctly

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, works as described with the
second patch applied as well.
Comment 9 Katrin Fischer 2014-08-15 17:17:05 UTC
Created attachment 30855 [details] [review]
[PASSED QA] Bug 12432 [QA Followup] - Make "All" tab work when switching back to it

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 10 Tomás Cohen Arazi 2014-08-19 15:42:13 UTC
Patches pushed to master.

Thanks Kyle!
Comment 11 Galen Charlton 2014-09-23 04:52:10 UTC
Pushed to 3.16.x for inclusion in 3.16.4.
Comment 12 Fridolin Somers 2014-12-08 13:27:41 UTC
Pushed to 3.14.x, will be in 3.14.12.