Bugzilla – Attachment 31394 Details for
Bug 12863
News in OPAC: HTML broken with nested p tags and multiple thead in same table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table
SIGNED-OFF-Bug-12863---News-in-OPAC-HTML-broken-wi.patch (text/plain), 2.29 KB, created by
Owen Leonard
on 2014-09-05 13:09:31 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12863 - News in OPAC: HTML broken with nested p tags and multiple thead in same table
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2014-09-05 13:09:31 UTC
Size:
2.29 KB
patch
obsolete
>From 6ce99154603c9a835a7c975d8262a346ea0f0b22 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Wed, 3 Sep 2014 12:10:26 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 12863 - News in OPAC: HTML broken with > nested p tags and multiple thead in same table >Content-Type: text/plain; charset="utf-8" > >This patch fixes broken HTML in OPAC news by replacing table display >with divs. > >To test: > >Create multiple news for OPAC >Validate with HTML validator or check source code >Result: >Error with nested p tags >Table header thead is repeated for every news (not allowed) >Bonus testing: Let a screen reader like NVDA read the news and try to >understand it with closed eyes. > >Apply patch >Result: >No more HTML errors in news >Screen reader reads news properly > >To style you can use classes newscontainer, newsitem, newsheader, >newsbody and newsfooter. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > .../opac-tmpl/bootstrap/en/modules/opac-main.tt | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >index 450506e..83835c7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt >@@ -38,14 +38,14 @@ > [% END %] > > [% IF ( koha_news_count ) %] >- <div id="news"> >- <table class="table table-bordered"> >- [% FOREACH koha_new IN koha_news %] >- <thead><tr><th>[% koha_new.title %]</th></tr></thead> >- <tbody><tr><td><p>[% koha_new.new %]</p> >- <p class="newsfooter"><i>(published on [% koha_new.newdate %])</i></p></td></tr></tbody> >- [% END %] >- </table> >+ <div id="news" class="newscontainer"> >+ [% FOREACH koha_new IN koha_news %] >+ <div class="newsitem"> >+ <h4 class="newsheader">[% koha_new.title %]</h4> >+ <div class="newsbody">[% koha_new.new %]</div> >+ <div class="newsfooter">(published on [% koha_new.newdate %])</div> >+ </div> >+ [% END %] > </div> > [% END %] > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12863
:
31333
|
31394
|
31395
|
31396
|
31398
|
31399
|
31443
|
31444
|
31445