Bugzilla – Attachment 32408 Details for
Bug 13085
bugfix : tools/export.pl don't works in commandline without id_list_file parameter
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 13085: bugfix to allow call of export.pl in commandline without id_list_file parameter
PASSED-QA-Bug-13085-bugfix-to-allow-call-of-export.patch (text/plain), 1.23 KB, created by
Katrin Fischer
on 2014-10-16 13:23:53 UTC
(
hide
)
Description:
[PASSED QA] Bug 13085: bugfix to allow call of export.pl in commandline without id_list_file parameter
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-10-16 13:23:53 UTC
Size:
1.23 KB
patch
obsolete
>From b2327986ad5e1d33133524c35704a56eb7242421 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?St=C3=A9phane=20Delaune?= <stephane.delaune@biblibre.com> >Date: Wed, 15 Oct 2014 15:23:35 +0200 >Subject: [PATCH] [PASSED QA] Bug 13085: bugfix to allow call of export.pl in > commandline without id_list_file parameter > >Test plan >1/ run ./tools/export.pl >2/ notice an error like cannot open 0: No such file or directory at ./tools/export.pl line 209. >3/ apply patch >4/ run again >5/ no errors > >Signed-off-by: Chris <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described, adding an additional check. >--- > tools/export.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/export.pl b/tools/export.pl >index 8a5c2a5..97415f8 100755 >--- a/tools/export.pl >+++ b/tools/export.pl >@@ -206,7 +206,7 @@ if ( $op eq "export" ) { > my $authtype = $query->param('authtype'); > my $filefh; > if ($commandline) { >- open $filefh,"<", $id_list_file or die "cannot open $id_list_file: $!"; >+ open $filefh,"<", $id_list_file or die "cannot open $id_list_file: $!" if $id_list_file; > } else { > $filefh = $query->upload("id_list_file"); > } >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13085
:
32333
|
32405
| 32408