Bug 13085 - bugfix : tools/export.pl don't works in commandline without id_list_file parameter
Summary: bugfix : tools/export.pl don't works in commandline without id_list_file para...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P2 major (vote)
Assignee: Stéphane Delaune
QA Contact: Testopia
URL:
Keywords:
: 13197 (view as bug list)
Depends on: 12238
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-15 13:03 UTC by Stéphane Delaune
Modified: 2016-12-05 21:22 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (925 bytes, patch)
2014-10-15 13:37 UTC, Stéphane Delaune
Details | Diff | Splinter Review
Bug 13085: bugfix to allow call of export.pl in commandline without id_list_file parameter (1.12 KB, patch)
2014-10-16 13:03 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 13085: bugfix to allow call of export.pl in commandline without id_list_file parameter (1.23 KB, patch)
2014-10-16 13:23 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Delaune 2014-10-15 13:03:25 UTC
call of tools/export.pl without id_list_file parameter leads to scripts's die with warning message :
cannot open 0: no such file or directory
Comment 1 Stéphane Delaune 2014-10-15 13:37:07 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-10-16 13:03:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-10-16 13:23:53 UTC
Created attachment 32408 [details] [review]
[PASSED QA] Bug 13085: bugfix to allow call of export.pl in commandline without id_list_file parameter

Test plan
1/ run ./tools/export.pl
2/ notice an error like cannot open 0: No such file or directory at ./tools/export.pl line 209.
3/ apply patch
4/ run again
5/ no errors

Signed-off-by: Chris <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, adding an additional check.
Comment 4 Tomás Cohen Arazi 2014-10-22 17:34:05 UTC
Patch pushed to master.

Thanks Stephane!
Comment 5 Kyle M Hall 2014-11-14 12:58:27 UTC
*** Bug 13197 has been marked as a duplicate of this bug. ***
Comment 6 Mason James 2015-04-23 03:22:02 UTC
Possible selection for 3.16.x
Comment 7 Mason James 2015-05-29 07:44:16 UTC
Bug not relevant for 3.16.x