Bugzilla – Attachment 32703 Details for
Bug 13129
HTML and JS escapes missing in unimarc_field_4XX.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt
Bug-13129---HTML-and-JS-escapes-missing-in-unimarc.patch (text/plain), 13.90 KB, created by
Chris Cormack
on 2014-10-25 03:42:50 UTC
(
hide
)
Description:
Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2014-10-25 03:42:50 UTC
Size:
13.90 KB
patch
obsolete
>From d89dffecb85dd935d5562d3e923bf0203a7abbed Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 22 Oct 2014 17:38:01 +0200 >Subject: [PATCH] Bug 13129 - HTML and JS escapes missing in > unimarc_field_4XX.tt > >This patch adds JS and HTML espaces are it is missing. >Replaces calls to url filter by uri filter, url filter does not espace enought caracters : http://template-toolkit.org/docs/manual/Filters.html#section_url. > >Also corrects the fact the code : resul.size => resul.item('size'). >Old code returns the size of the loop instead of the value of "size" field. > >Test plan : > - Use the plugin unimarc_field_4XX > - Perform a search with a ? or & >=> Search works > - Perform a search that returns a record with a double quote in title > - Choose this record >=> Plugin works > - Check the results displays well the value of biblioitems.size > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../cataloguing/value_builder/unimarc_field_4XX.tt | 64 +++++++++++----------- > 1 file changed, 32 insertions(+), 32 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >index 67dcb3e..d190469 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_4XX.tt >@@ -25,46 +25,46 @@ > var subfield = subfields[i+1]; > > if(code.value == '9'){ >- subfield.value = "[% subfield_value_9 %]"; >+ subfield.value = "[% subfield_value_9 |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == '0'){ >- subfield.value = "[% subfield_value_0 %]"; >+ subfield.value = "[% subfield_value_0 |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'a'){ >- subfield.value = "[% subfield_value_a %]"; >+ subfield.value = "[% subfield_value_a |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'c'){ >- subfield.value = "[% subfield_value_c %]"; >+ subfield.value = "[% subfield_value_c |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'd'){ >- subfield.value = "[% subfield_value_d %]"; >+ subfield.value = "[% subfield_value_d |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'e'){ >- subfield.value = "[% subfield_value_e %]"; >+ subfield.value = "[% subfield_value_e |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'h'){ >- subfield.value = "[% subfield_value_h %]"; >+ subfield.value = "[% subfield_value_h |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'i'){ >- subfield.value = "[% subfield_value_i %]"; >+ subfield.value = "[% subfield_value_i |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'p'){ >- subfield.value = "[% subfield_value_p %]"; >+ subfield.value = "[% subfield_value_p |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 't'){ >- subfield.value = "[% subfield_value_t %]"; >+ subfield.value = "[% subfield_value_t |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'u'){ >- subfield.value = "[% subfield_value_u %]"; >+ subfield.value = "[% subfield_value_u |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'v'){ >- subfield.value = "[% subfield_value_v %]"; >+ subfield.value = "[% subfield_value_v |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'x'){ >- subfield.value = "[% subfield_value_x %]"; >+ subfield.value = "[% subfield_value_x |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > if(code.value == 'y'){ >- subfield.value = "[% subfield_value_y %]"; >+ subfield.value = "[% subfield_value_y |replace("'", "\'") |replace('"', '\"') |replace('\n', '\\n') |replace('\r', '\\r') %]"; > } > } > } >@@ -121,9 +121,9 @@ > <option value="">All item types</option> > [% FOREACH itypeloo IN itypeloop %] > [% IF ( itypeloo.selected ) %] >- <option value="[% itypeloo.itemtype %]" selected="selected">[% itypeloo.description %]</option> >+ <option value="[% itypeloo.itemtype %]" selected="selected">[% itypeloo.description |html %]</option> > [% ELSE %] >- <option value="[% itypeloo.itemtype %]">[% itypeloo.description %]</option> >+ <option value="[% itypeloo.itemtype %]">[% itypeloo.description |html %]</option> > [% END %] > [% END %] > </select> >@@ -140,14 +140,14 @@ > > <h2>Search results</h2> > <div id="UNIMARC_Field_4XX_resultnumber"> >- <p>[% IF ( displayprev ) %] <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% startfromprev %]&search=[% search %]&resultsperpage=[% resultsperpage %]&type=intranet&op=do_search"><< Previous</a>[% END %] >+ <p>[% IF ( displayprev ) %] <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% startfromprev %]&search=[% search |uri %]&resultsperpage=[% resultsperpage %]&type=intranet&op=do_search"><< Previous</a>[% END %] > [% FOREACH number IN numbers %] > [% IF ( number.highlight ) %] <span class="highlight">[% number.number %]</span> >- [% ELSE %] <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% number.startfrom %]&search=[% number.search |url %]&resultsperpage=[% number.resultsperpage %]&type=intranet&op=do_search">[% number.number %]</a> >+ [% ELSE %] <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% number.startfrom %]&search=[% number.search |uri %]&resultsperpage=[% number.resultsperpage %]&type=intranet&op=do_search">[% number.number %]</a> > [% END %] > [% END %] > [% IF ( displaynext ) %] >- <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% startfromnext %]&search=[% search %]&resultsperpage=[% resultsperpage %]&type=intranet&op=do_search">Next>></a> >+ <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% startfromnext %]&search=[% search |uri %]&resultsperpage=[% resultsperpage %]&type=intranet&op=do_search">Next>></a> > [% END %]</p> > <p class="resultcount"> > [% IF ( total ) %]Results [% from %] to [% to %] of [% total %] >@@ -167,24 +167,24 @@ > [% IF ( resul.even ) %]<td class="hilighted"> > [% ELSE %]<td>[% END %] > [% IF ( resul.MARC_ON ) %] >- <a_class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a> >+ <a_class="transparent resultlist" href="/cgi-bin/koha/MARCdetail.pl?biblionumber=[% resul.biblionumber |uri %]">[% resul.title |html %]</a> > [% ELSE %] >- <a_class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |url %]">[% resul.title |html %]</a> [% END %] >- <p>[% resul.author %] >- [% IF ( resul.publishercode ) %]- [% resul.publishercode %][% END %] >- [% IF ( resul.place ) %] ; [% resul.place %][% END %] >- [% IF ( resul.pages ) %] - [% resul.pages %][% END %] >- [% IF ( resul.notes ) %] : [% resul.notes %][% END %] >- [% IF ( resul.size ) %] ; [% resul.size %][% END %] >+ <a_class="transparent resultlist" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% resul.biblionumber |uri %]">[% resul.title |html %]</a> [% END %] >+ <p>[% resul.author |html %] >+ [% IF ( resul.publishercode ) %]- [% resul.publishercode |html %][% END %] >+ [% IF ( resul.place ) %] ; [% resul.place |html %][% END %] >+ [% IF ( resul.pages ) %] - [% resul.pages |html %][% END %] >+ [% IF ( resul.notes ) %] : [% resul.notes |html %][% END %] >+ [% IF ( resul.item('size') ) %] ; [% resul.item('size') |html %][% END %] > </p> > </td> > [% IF ( resul.even ) %]<td align="center" class="hilighted"> > [% ELSE %]<td align="center">[% END %] >- [% resul.totitem %] >+ [% resul.totitem |html %] > </td> > [% IF ( resul.even ) %]<td class="hilighted"> > [% ELSE %]<td>[% END %] >- [% resul.CN %] >+ [% resul.CN |html %] > </td> > <td> > [% IF ( resul.biblionumber ) %] >@@ -201,7 +201,7 @@ > <div id="resultnumber"> > <p> > [% IF ( displayprev ) %] >- <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index %]&amp;startfrom=[% startfromprev %]&amp;search=[% search |url %]&amp;resultsperpage=[% resultsperpage %]&amp;type=intranet&amp;op=do_search"> >+ <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&amp;index=[% index %]&amp;startfrom=[% startfromprev %]&amp;search=[% search |uri %]&amp;resultsperpage=[% resultsperpage %]&amp;type=intranet&amp;op=do_search"> > << Previous > </a> > [% END %] >@@ -212,14 +212,14 @@ > [% number.number %] > </span> > [% ELSE %] >- <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% number.startfrom %]&search=[% number.search %]&resultsperpage=[% number.resultsperpage %]&type=intranet&op=do_search"> >+ <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% number.startfrom %]&search=[% number.search |uri %]&resultsperpage=[% number.resultsperpage %]&type=intranet&op=do_search"> > [% number.number %] > </a> > [% END %] > [% END %] > > [% IF ( displaynext ) %] >- <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% startfromnext %]&search=[% search %]&resultsperpage=[% resultsperpage %]&type=intranet&op=do_search"> >+ <a class="resultnumber" href="/cgi-bin/koha/cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_4XX.pl&index=[% index %]&startfrom=[% startfromnext %]&search=[% search |uri %]&resultsperpage=[% resultsperpage %]&type=intranet&op=do_search"> > Next>> > </a> > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 13129
:
32583
|
32703
|
32728