In cataloging plugin unimarc_field_4XX.tt some template vars should be HTML or JS escaped in case they contain characters of the language.
Created attachment 32583 [details] [review] Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt This patch adds JS and HTML espaces are it is missing. Replaces calls to url filter by uri filter, url filter does not espace enought caracters : http://template-toolkit.org/docs/manual/Filters.html#section_url. Also corrects the fact the code : resul.size => resul.item('size'). Old code returns the size of the loop instead of the value of "size" field. Test plan : - Use the plugin unimarc_field_4XX - Perform a search with a ? or & => Search works - Perform a search that returns a record with a double quote in title - Choose this record => Plugin works - Check the results displays well the value of biblioitems.size
Created attachment 32703 [details] [review] Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt This patch adds JS and HTML espaces are it is missing. Replaces calls to url filter by uri filter, url filter does not espace enought caracters : http://template-toolkit.org/docs/manual/Filters.html#section_url. Also corrects the fact the code : resul.size => resul.item('size'). Old code returns the size of the loop instead of the value of "size" field. Test plan : - Use the plugin unimarc_field_4XX - Perform a search with a ? or & => Search works - Perform a search that returns a record with a double quote in title - Choose this record => Plugin works - Check the results displays well the value of biblioitems.size Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 32728 [details] [review] [PASSED QA] Bug 13129 - HTML and JS escapes missing in unimarc_field_4XX.tt This patch adds JS and HTML espaces are it is missing. Replaces calls to url filter by uri filter, url filter does not espace enough characters: http://template-toolkit.org/docs/manual/Filters.html#section_url. Also corrects the fact the code: resul.size => resul.item('size'). Old code returns the size of the loop instead of the value of "size" field. Test plan : - Use the plugin unimarc_field_4XX - Perform a search with a ? or & => Search works - Perform a search that returns a record with a double quote in title - Choose this record => Plugin works - Check the results displays well the value of biblioitems.size Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, I fixed some tabs. Tested in a UNIMARC installation.
Patch pushed to master. Thanks Fridolin!