Bugzilla – Attachment 40746 Details for
Bug 14482
Warns when exporting patron's checked-in barcodes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14482: Silences warns triggered when exporting patron's checked in barcodes
Bug-14482-Silences-warns-triggered-when-exporting-.patch (text/plain), 1.24 KB, created by
Aleisha Amohia
on 2015-07-01 05:30:40 UTC
(
hide
)
Description:
Bug 14482: Silences warns triggered when exporting patron's checked in barcodes
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2015-07-01 05:30:40 UTC
Size:
1.24 KB
patch
obsolete
>From 19314fc949ecfdee76bbf0c37c50804ed3c714e5 Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Wed, 1 Jul 2015 02:45:42 +0000 >Subject: [PATCH] Bug 14482: Silences warns triggered when exporting patron's > checked in barcodes > >Use of uninitialized value $borrowercardnumber > >To test: >1) Go to any patron page (ie http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=1369), click 'More' then 'Export today's checked in barcodes' >2) Notice warns in error log >3) Click cancel on the pop-up >4) Apply patch, reload page, click 'More' then 'Export today's checked in barcodes' again >5) Notice warns are gone and page still works correctly >--- > members/readingrec.pl | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/members/readingrec.pl b/members/readingrec.pl >index 62e653e..e141e79 100755 >--- a/members/readingrec.pl >+++ b/members/readingrec.pl >@@ -83,6 +83,7 @@ if ( $op eq 'export_barcodes' ) { > map { $_->{barcode} } grep { $_->{returndate} =~ m/^$today/o } @{$issues}; > my $borrowercardnumber = > GetMember( borrowernumber => $borrowernumber )->{'cardnumber'}; >+ $borrowercardnumber //= ''; > my $delimiter = "\n"; > binmode( STDOUT, ":encoding(UTF-8)" ); > print $input->header( >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14482
: 40746