Bugzilla – Attachment 44155 Details for
Bug 15083
acqui/currency.pl is unused
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15083: Remove acqui/currency.pl
Bug-15083-Remove-acquicurrencypl.patch (text/plain), 3.02 KB, created by
Jonathan Druart
on 2015-10-29 14:46:05 UTC
(
hide
)
Description:
Bug 15083: Remove acqui/currency.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-10-29 14:46:05 UTC
Size:
3.02 KB
patch
obsolete
>From 12cf29afe5d4acce8cfba144df9e9c19804520f9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 29 Oct 2015 14:43:58 +0000 >Subject: [PATCH] Bug 15083: Remove acqui/currency.pl > >This script has scary FIXMEs and can be removed. >It is never called from Koha code. >On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, >which was only called from this script. > >Test plan: > git grep 'acqui/currency.pl >and > git grep ModCurrencies >should not return anything. >--- > C4/Budgets.pm | 20 -------------------- > acqui/currency.pl | 42 ------------------------------------------ > 2 files changed, 62 deletions(-) > delete mode 100755 acqui/currency.pl > >diff --git a/C4/Budgets.pm b/C4/Budgets.pm >index f2f376a..d90246c 100644 >--- a/C4/Budgets.pm >+++ b/C4/Budgets.pm >@@ -61,7 +61,6 @@ BEGIN { > > &GetCurrency > &GetCurrencies >- &ModCurrencies > &ConvertCurrency > > &GetBudgetsPlanCell >@@ -956,25 +955,6 @@ sub GetCurrency { > return $r; > } > >-=head2 ModCurrencies >- >-&ModCurrencies($currency, $newrate); >- >-Sets the exchange rate for C<$currency> to be C<$newrate>. >- >-=cut >- >-sub ModCurrencies { >- my ( $currency, $rate ) = @_; >- my $dbh = C4::Context->dbh; >- my $query = qq| >- UPDATE currency >- SET rate=? >- WHERE currency=? |; >- my $sth = $dbh->prepare($query); >- $sth->execute( $rate, $currency ); >-} >- > # ------------------------------------------------------------------- > > =head2 ConvertCurrency >diff --git a/acqui/currency.pl b/acqui/currency.pl >deleted file mode 100755 >index b7154b7..0000000 >--- a/acqui/currency.pl >+++ /dev/null >@@ -1,42 +0,0 @@ >-#!/usr/bin/perl >- >-#script to display and update currency rates >- >-# Copyright 2000-2002 Katipo Communications >-# Copyright 2008-2009 BibLibre SARL >-# >-# This file is part of Koha. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use strict; >-use warnings; >-use CGI qw ( -utf8 ); >-use C4::Acquisition; >-use C4::Biblio; >-use C4::Budgets; >- >-# FIXME: CHECK AUTH >-# FIXME: This should be part of another script, not a throwaway standalone. >-# FIXME: params should have better checks before passed to ModCurrencies >-# FIXME: need error handling if ModCurrencies FAILS. >- >-my $input = new CGI; >- >-foreach my $param ($input->param) { >- if ($param ne 'type' && $param !~ /submit/) { >- ModCurrencies($param, $input->param($param)); >- } >-} >-print $input->redirect('/cgi-bin/koha/acqui/acqui-home.pl'); >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15083
:
44155
|
44158
|
44458