This script is never called from the Koha code and should be removed (especially regarding the FIXME...)
Created attachment 44155 [details] [review] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything.
Created attachment 44158 [details] [review] [SIGNED-OFF] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more ModeCurrencies, no call to acqui/currency.pl No errors
Created attachment 44458 [details] [review] [PASSED QA] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No more ModeCurrencies, no call to acqui/currency.pl No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!