Bugzilla – Attachment 45310 Details for
Bug 12152
Holds to pull report should show library and itype description instead of their codes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12152: Holds to pull report - Show branch names and item type descriptions
Bug-12152-Holds-to-pull-report---Show-branch-names.patch (text/plain), 2.41 KB, created by
Jonathan Druart
on 2015-12-02 10:33:05 UTC
(
hide
)
Description:
Bug 12152: Holds to pull report - Show branch names and item type descriptions
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2015-12-02 10:33:05 UTC
Size:
2.41 KB
patch
obsolete
>From 2e2294eb3ce280d591b3cefbaa1a03bb71a36099 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 22 Nov 2015 03:38:30 +0100 >Subject: [PATCH] Bug 12152: Holds to pull report - Show branch names and item > type descriptions > >The 'Holds to pull' report shows branch and itemtype codes without >this patch. With the patch, names and descriptions should display. > >To test: >- Make sure there are some holds for available items in your system >- Go to Circulation > Holds to pull >- Verify changes mentioned above in the list of holds shown > >Signed-off-by: David Cook <dcook@prosentient.com.au> > >Works as described, although as Magnus mentioned, Locations >still use codes instead of descriptions. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >index d6013f8..8e11dc6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt >@@ -1,4 +1,6 @@ > [% USE KohaDates %] >+[%- USE Branches -%] >+[%- USE ItemTypes -%] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Circulation › Holds to pull</title> > [% INCLUDE 'doc-head-close.inc' %] >@@ -123,14 +125,14 @@ $(document).ready(function() { > <td>"</td> > <td>"</td> > [% END %] >- <td>[% reserveloo.holdingbranch %]</td> >+ <td>[% Branches.GetName ( reserveloo.holdingbranch ) %]</td> > <td><p>[% reserveloo.itemcallnumber %]</p></td> > <td><p>[% reserveloo.copyno %]</p></td> > <td><p>[% reserveloo.enumchron %]</p></td> >- <td>[% reserveloo.itype %]</td> >+ <td>[% ItemTypes.GetDescription( reserveloo.itype ) %]</td> > <td>[% reserveloo.location %]</td> > <td> >- <span title="[% reserveloo.reservedate %]">[% reserveloo.reservedate | $KohaDates %] in [% reserveloo.branch %]</span> >+ <span title="[% reserveloo.reservedate %]">[% reserveloo.reservedate | $KohaDates %] in [% Branches.GetName ( reserveloo.branch ) %]</span> > [% IF ( reserveloo.statusw ) %]<p>Waiting</p>[% END %][% IF ( reserveloo.statusf ) %]<p>Fullfilled</p>[% END %] > </td> > </tr> >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12152
:
45085
|
45114
|
45162
|
45174
| 45310 |
45311