The holds to pull report shows the library code and itype codes instead of the descriptions.
Still valid.
... and still valid.
Locations (authorized value LOC) also show the codes instead of descriptions.
Created attachment 45085 [details] [review] Bug 12152: Holds to pull report - Show branch names and item type descriptions The 'Holds to pull' report shows branch and itemtype codes without this patch. With the patch, names and descriptions should display. To test: - Make sure there are some holds for available items in your system - Go to Circulation > Holds to pull - Verify changes mentioned above in the list of holds shown
Created attachment 45114 [details] [review] Bug 12152: Holds to pull report - Show branch names and item type descriptions The 'Holds to pull' report shows branch and itemtype codes without this patch. With the patch, names and descriptions should display. To test: - Make sure there are some holds for available items in your system - Go to Circulation > Holds to pull - Verify changes mentioned above in the list of holds shown Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described, although as Magnus mentioned, Locations still use codes instead of descriptions.
Created attachment 45162 [details] [review] Bug 12152: Holds to pull report - Display location descriptions ...instead of their code Test plan: Same as before, confirm the the location codes are replaced with their descriptions.
Created attachment 45174 [details] [review] [SIGNED OFF] Bug 12152: Holds to pull report - Display location descriptions ...instead of their code Test plan: Same as before, confirm the the location codes are replaced with their descriptions. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 45310 [details] [review] Bug 12152: Holds to pull report - Show branch names and item type descriptions The 'Holds to pull' report shows branch and itemtype codes without this patch. With the patch, names and descriptions should display. To test: - Make sure there are some holds for available items in your system - Go to Circulation > Holds to pull - Verify changes mentioned above in the list of holds shown Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described, although as Magnus mentioned, Locations still use codes instead of descriptions. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 45311 [details] [review] Bug 12152: Holds to pull report - Display location descriptions ...instead of their code Test plan: Same as before, confirm the the location codes are replaced with their descriptions. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Patches pushed to master. Thanks Katrin and Jonathan!
Patches pushed to 3.22.x, will be in 3.22.1
This patch has been pushed to 3.20.x, will be in 3.20.7.
Pushed to 3.18.13, and released.
Replacement of code with name doesn't work for a list of codes. See bug 15560