Bugzilla – Attachment 47127 Details for
Bug 15617
Be able to close "Click to edit" text boxes after opening them
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] 15617 - Be able to close "Click to edit" text boxes after opening them
SIGNED-OFF-15617---Be-able-to-close-Click-to-edit-.patch (text/plain), 3.07 KB, created by
Owen Leonard
on 2016-01-21 14:57:14 UTC
(
hide
)
Description:
[SIGNED-OFF] 15617 - Be able to close "Click to edit" text boxes after opening them
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-01-21 14:57:14 UTC
Size:
3.07 KB
patch
obsolete
>From fd7d029ab6997530d450aca29da51d4cde7bce0d Mon Sep 17 00:00:00 2001 >From: Gus <gel1163@stacmail.net> >Date: Wed, 20 Jan 2016 23:47:12 +0000 >Subject: [PATCH] [SIGNED-OFF] 15617 - Be able to close "Click to edit" text > boxes after opening them >Content-Type: text/plain; charset="utf-8" > >To test: > >1. Go to admin preferences, Acquisitions, Policy. >2. Find MarcFieldsToOrder and click "Click to Edit" >3. Notice that a "Click to collapse" button appears, click it. >4. Notice that the box has collapsed > >This fix should be applicable to all "Click to Edit" textboxes > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Works well, and a nice improvement. >--- > koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js | 12 +++++++++++- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 3 ++- > 2 files changed, 13 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >index b6537d9..54286de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >+++ b/koha-tmpl/intranet-tmpl/prog/en/js/pages/preferences.js >@@ -96,13 +96,23 @@ $( document ).ready( function () { > } ); > > $( '.prefs-tab .expand-textarea' ).show().click( function () { >- $( this ).hide().nextAll( 'textarea, input[type=submit]' ) >+ $( this ).hide().nextAll( 'textarea, input[type=submit], a' ) > .animate( { height: 'show', queue: false } ) > .animate( { opacity: 1 } ); > > return false; > } ).nextAll( 'textarea, input[type=submit]' ).hide().css( { opacity: 0 } ); > >+ $( '.prefs-tab .collapse-textarea' ).hide().click( function () { >+ $( this ).show().prevAll( 'textarea, input[type=submit]' ) >+ .animate( { height: 'hide', queue: false } ) >+ .animate( { opacity: 0 } ); >+ >+ $( this ).hide().prevAll( 'a' ).show(); >+ return false; >+ }); >+ >+ > $("h3").attr("class","expanded").attr("title",MSG_CLICK_TO_EXPAND); > var collapsible = $(".collapsed,.expanded"); > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >index 9d4b95f..e42aca2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt >@@ -60,7 +60,7 @@ > > <div id="bd"> > <div id="yui-main"> >- <div class="yui-b"> >+ <div class="yui-b"> > > [% IF ( jump_not_found ) %] > <h2>System preferences</h2> >@@ -141,6 +141,7 @@ > [% ELSE %] > <a class="expand-textarea" style="display: none" href="#">Click to Edit</a> > <textarea name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "short" %]" rows="10" cols="40">[% CHUNK.value %]</textarea> >+ <a class="collapse-textarea" style="display:none" href="#">Click to collapse</br></a> > [% END %] > [% ELSIF ( CHUNK.type_languages ) %] > <dl> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15617
:
46953
|
47069
|
47071
|
47127
|
47132