Bug 15617 - Be able to close "Click to edit" text boxes after opening them
Summary: Be able to close "Click to edit" text boxes after opening them
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Gus Ellerm
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-19 22:35 UTC by Aleisha Amohia
Modified: 2017-06-14 22:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Click to edit text box on syspref (18.63 KB, image/png)
2016-01-19 22:35 UTC, Aleisha Amohia
Details
15617 - Be able to close "Click to edit" text boxes after opening them Test - 1. Go to admin preferences, Acquisitions, Policy. 2. Find MarcFieldsToOrder and click "Click to Edit" 3. Notice that a "Click to collapse" button appears, click it. 4. Notice th (2.94 KB, patch)
2016-01-20 23:51 UTC, Gus Ellerm
Details | Diff | Splinter Review
15617 - Be able to close "Click to edit" text boxes after opening them Test (2.93 KB, patch)
2016-01-21 00:47 UTC, Gus Ellerm
Details | Diff | Splinter Review
[SIGNED-OFF] 15617 - Be able to close "Click to edit" text boxes after opening them (3.07 KB, patch)
2016-01-21 14:57 UTC, Owen Leonard
Details | Diff | Splinter Review
15617 - Be able to close "Click to edit" text boxes after opening them (3.09 KB, patch)
2016-01-21 15:17 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2016-01-19 22:35:59 UTC
Created attachment 46953 [details]
Click to edit text box on syspref

I think that once you have opened a 'Click to edit' text box, you should be able to click a 'Cancel' or 'Hide' button and close it again. I realise you are able to collapse the box down by dragging the corner, but it would be nice to have a show and hide function.

Leaving for someone better at javascript than me to figure out.

I think preferences.tt and systempreferences.tt are the only files that have 'Click to edit' text boxes.
Comment 1 Gus Ellerm 2016-01-20 23:51:33 UTC Comment hidden (obsolete)
Comment 2 Gus Ellerm 2016-01-21 00:47:58 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2016-01-21 14:57:14 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2016-01-21 15:17:49 UTC
Created attachment 47132 [details] [review]
15617 - Be able to close "Click to edit" text boxes after opening them

To test:

1. Go to admin preferences, Acquisitions, Policy.
2. Find MarcFieldsToOrder and click "Click to Edit"
3. Notice that a "Click to collapse" button appears, click it.
4. Notice that the box has collapsed

This fix should be applicable to all "Click to Edit" textboxes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Works well, and a nice improvement.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Brendan Gallagher 2016-01-27 05:33:42 UTC
Pushed to Master - Should be in the May 2016 release. Thanks!