Bugzilla – Attachment 47579 Details for
Bug 15416
Warns on Guided Reports page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15416: Warns on guided_reports.pl
Bug-15416-Warns-on-guidedreportspl.patch (text/plain), 1.26 KB, created by
Jonathan Druart
on 2016-02-03 12:29:50 UTC
(
hide
)
Description:
Bug 15416: Warns on guided_reports.pl
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-02-03 12:29:50 UTC
Size:
1.26 KB
patch
obsolete
>From 35d3ba7f6b14879d80975824eb469b78582eb16d Mon Sep 17 00:00:00 2001 >From: Aleisha <aleishaamohia@hotmail.com> >Date: Mon, 18 Jan 2016 03:30:44 +0000 >Subject: [PATCH] Bug 15416: Warns on guided_reports.pl > >Initialising $phase variable to be '' if not defined. > >To test: >1) Go to Reports -> Guided Reports Wizard >2) Notice warns >3) Apply patch >4) Refresh page >5) Confirm warns are gone and page still works as it should > >Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> >Warns are gone. Page still works as expected > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended patch: >-my $phase = $input->param('phase'); >-$phase //= ''; >+my $phase = $input->param('phase') // ''; >--- > reports/guided_reports.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index 6a03e11..ceba539 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -47,7 +47,7 @@ Script to control the guided report creation > my $input = new CGI; > my $usecache = C4::Context->ismemcached; > >-my $phase = $input->param('phase'); >+my $phase = $input->param('phase') // ''; > my $flagsrequired; > if ( $phase eq 'Build new' or $phase eq 'Delete Saved' ) { > $flagsrequired = 'create_reports'; >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15416
:
46761
|
47568
| 47579