Bug 15416 - Warns on Guided Reports page
Summary: Warns on Guided Reports page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-22 23:43 UTC by Aleisha Amohia
Modified: 2017-06-14 22:11 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 15416: Warns on guided_reports.pl (922 bytes, patch)
2016-01-18 03:33 UTC, Aleisha Amohia 		Details | Diff | Splinter Review
[SIGNED-OFF]Bug 15416: Warns on guided_reports.pl (1.01 KB, patch)
2016-02-02 21:04 UTC, Héctor Eduardo Castro Avalos 		Details | Diff | Splinter Review
Bug 15416: Warns on guided_reports.pl (1.26 KB, patch)
2016-02-03 12:29 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2015-12-22 23:43:33 UTC 
guided_reports.pl: Use of uninitialized value $phase in string eq at /home/vagrant/kohaclone/reports/guided_reports.pl line 52
guided_reports.pl: Use of uninitialized value $phase in string eq at /home/vagrant/kohaclone/reports/guided_reports.pl line 52
guided_reports.pl: Use of uninitialized value $phase in string eq at /home/vagrant/kohaclone/reports/guided_reports.pl line 55

To reproduce, go to Tools -> Guided reports wizard
Comment 1 Aleisha Amohia 2016-01-18 03:33:01 UTC Comment hidden (obsolete)
Comment 2 Héctor Eduardo Castro Avalos 2016-02-02 19:58:14 UTC 
Hi Aleisha

I can't reproduce the issue, could you please confirm?
Comment 3 Aleisha Amohia 2016-02-02 20:01:32 UTC 
This is still valid for me on version 3.23 of Koha
Comment 4 Héctor Eduardo Castro Avalos 2016-02-02 21:00:07 UTC 
(In reply to Aleisha Amohia from comment #3)
> This is still valid for me on version 3.23 of Koha

Pardon me I didn't know that i needed to consult the log files.
Comment 5 Héctor Eduardo Castro Avalos 2016-02-02 21:04:26 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2016-02-03 12:29:50 UTC 
Created attachment 47579 [details] [review]
Bug 15416: Warns on guided_reports.pl

Initialising $phase variable to be '' if not defined.

To test:
1) Go to Reports -> Guided Reports Wizard
2) Notice warns
3) Apply patch
4) Refresh page
5) Confirm warns are gone and page still works as it should

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Warns are gone. Page still works as expected

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch:
-my $phase = $input->param('phase');
-$phase //= '';
+my $phase = $input->param('phase') // '';
Comment 7 Brendan Gallagher 2016-02-24 03:16:41 UTC 
Pushed to Master - Should be in the May 2016 release.  Thanks!
Comment 8 Julian Maurice 2016-02-26 15:40:16 UTC 
Patch pushed to 3.22.x, will be in 3.22.4
Comment 9 Frédéric Demians 2016-03-01 16:54:28 UTC 
This patch has been pushed to 3.20.x, will be in 3.20.9.