Bugzilla – Attachment 48540 Details for
Bug 15888
Syndetics Reviews preference should not enable LibraryThing reviews
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews
Bug-15888---Syndetics-Reviews-preference-should-no.patch (text/plain), 4.02 KB, created by
Chris Cormack
on 2016-03-02 08:29:15 UTC
(
hide
)
Description:
Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2016-03-02 08:29:15 UTC
Size:
4.02 KB
patch
obsolete
>From 5019e89a289c40f04edc1c0a408d0ef6e9a48090 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 23 Feb 2016 20:41:57 +0000 >Subject: [PATCH] Bug 15888 - Syndetics Reviews preference should not enable > LibraryThing reviews > >To test: >1 - Enable Syndetics Reviews without a LibraryThing ID >2 - Check page source and note you have a stanza for LTFL tabbed reveiws >3 - Apply patch >4 - Reload page and note LTFL tabbed reviews are not present >5 - Enter a LibraryThing ID and not the tab is restored. > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >--- > .../opac-tmpl/bootstrap/en/modules/opac-detail.tt | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 6c17888..abe9769 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -561,16 +561,18 @@ > [% IF ( SyndeticsExcerpt && SYNDETICS_EXCERPT ) %] > <li id="tab_excerpt"> <a href="#excerpt">Excerpt</a></li> > [% END %] >- [% IF ( SyndeticsReviews && SYNDETICS_REVIEWS ) %] >+ [% IF ( ( SyndeticsReviews && SYNDETICS_REVIEWS ) || ( LibraryThingForLibrariesTabbedView && LibraryThingForLibrariesID) ) %] > <li id="tab_reviews"> <a href="#reviews">Reviews</a></li> >- <li id="tab_LTFLreviews"> >- [% IF ( using_https ) %] >- <script src="https://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> >- <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="https://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> >- [% ELSE %] >- <script src="http://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> >- <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="http://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> >- [% END %] >+ [% IF ( LibraryThingForLibrariesID ) %] >+ <li id="tab_LTFLreviews"> >+ [% IF ( using_https ) %] >+ <script src="https://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> >+ <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="https://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> >+ [% ELSE %] >+ <script src="http://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> >+ <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="http://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> >+ [% END %] >+ [% END %] > </li> > [% END %] > [% IF ( SyndeticsAuthorNotes && SYNDETICS_ANOTES ) %] >-- >2.7.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15888
:
48320
|
48540
|
49519