On opac-detail.pl the code below attempts to retrieve LibraryThing content when SyndeticsReviews are enabled even if the librarything prefs are not turned on 564 [% IF ( SyndeticsReviews && SYNDETICS_REVIEWS ) %] 565 <li id="tab_reviews"> <a href="#reviews">Reviews</a></li> 566 <li id="tab_LTFLreviews"> 567 [% IF ( using_https ) %] 568 <script src="https://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> 569 <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="https://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> 570 [% ELSE %] 571 <script src="http://www.librarything.com/forlibraries/widget.js?id=[% LibraryThingForLibrariesID %]" type="text/javascript"></script> 572 <noscript>This page contains enriched content visible when JavaScript is enabled or by clicking <a href="http://www.librarything.com/forlibraries/noscript.php?id=[% LibraryThingForLibrariesID %]&accessibility=1">here</a>.</noscript> 573 [% END %] 57 </li> 575 [% END %]
Created attachment 48320 [details] [review] Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored.
Created attachment 48540 [details] [review] Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 49519 [details] [review] [PASSED QA] Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in May 2016 release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.6
Pushed to 3.20.x, will be in 3.20.11.