Bugzilla – Attachment 48690 Details for
Bug 15961
Use Font Awesome icons for confirmation of currency deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion
PASSED-QA-Bug-15961---Use-Font-Awesome-icons-for-c.patch (text/plain), 2.74 KB, created by
Owen Leonard
on 2016-03-04 14:03:19 UTC
(
hide
)
Description:
[PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2016-03-04 14:03:19 UTC
Size:
2.74 KB
patch
obsolete
>From af9b63d28c32c23170f1811273efbcadb44029c6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 2 Mar 2016 12:35:56 -0500 >Subject: [PATCH] [PASSED QA] Bug 15961 - Use Font Awesome icons for > confirmation of currency deletion >Content-Type: text/plain; charset="utf-8" > >When deleting a currency, the confirmation and error dialogs should use >Font Awesome icons. This patch makes this change. > >To test, apply the patch and go to Administration -> Currencies and >exchange rates. > >- Click the "delete" link next to any currency. >- Verify that the confirmation dialog is correctly styled. > - Test the both cancel and confirm operations. > - Verify that the deletion confirmation dialog is correctly styled. > >Bug 15962 prevents testing the error dialog which should appear if you >try to delete a currency which is use (defined as a currency in a vendor >record). To test this error you could manually enter a currency code >into aqbooksellers.currency and then try to delete that currency. > >Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >index 99557a2..305e471 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt >@@ -129,7 +129,7 @@ > <h3>Cannot delete currency <span class="ex">'[% currency.currency %]'</span></h3> > <p>This currency is used by [% nb_of_orders %] orders. Deletion not possible</p> > <form action="/cgi-bin/koha/admin/currency.pl" method="post"> >- <input type="submit" value="OK" class="approve" /> >+ <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> OK</button> > </form> > </div> > [% ELSE %] >@@ -146,10 +146,10 @@ > <form action="/cgi-bin/koha/admin/currency.pl" method="post"> > <input type="hidden" name="op" value="delete_confirmed" /> > <input type="hidden" name="currency_code" value="[% currency.currency_code %]" /> >- <input type="submit" class="approve" value="Delete this currency" /> >+ <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete this currency</button> > </form> > <form action="/cgi-bin/koha/admin/currency.pl" method="post"> >- <input type="submit" class="deny" value="No, do not delete" /> >+ <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button> > </form> > </div> > [% END %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15961
:
48555
|
48563
|
48584
| 48690