Bug 15961 - Use Font Awesome icons for confirmation of currency deletion
Summary: Use Font Awesome icons for confirmation of currency deletion
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/currency.pl?op=de...
Keywords:
Depends on: 15785
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-02 17:12 UTC by Owen Leonard
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 15961 - Use Font Awesome icons for confirmation of currency deletion (3.00 KB, patch)
2016-03-02 17:42 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion (3.03 KB, patch)
2016-03-02 19:59 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion (3.08 KB, patch)
2016-03-03 06:56 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion (2.74 KB, patch)
2016-03-04 14:03 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2016-03-02 17:12:26 UTC
When deleting a currency, the confirmation and error dialogs should use Font Awesome icons.
Comment 1 Owen Leonard 2016-03-02 17:42:00 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2016-03-02 19:59:58 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-03-03 06:56:02 UTC Comment hidden (obsolete)
Comment 4 Brendan Gallagher 2016-03-03 22:58:56 UTC
Needs some rebasing Owen - Thanks!
Comment 5 Owen Leonard 2016-03-04 14:03:19 UTC
Created attachment 48690 [details] [review]
[PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion

When deleting a currency, the confirmation and error dialogs should use
Font Awesome icons. This patch makes this change.

To test, apply the patch and go to Administration -> Currencies and
exchange rates.

- Click the "delete" link next to any currency.
- Verify that the confirmation dialog is correctly styled.
  - Test the both cancel and confirm operations.
  - Verify that the deletion confirmation dialog is correctly styled.

Bug 15962 prevents testing the error dialog which should appear if you
try to delete a currency which is use (defined as a currency in a vendor
record). To test this error you could manually enter a currency code
into aqbooksellers.currency and then try to delete that currency.

Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Brendan Gallagher 2016-03-07 17:48:07 UTC
Pushed to Master - Thanks! Should be in the May 2016 release.